fix: validate model exists in settings.toml#36
Open
NishchayMahor wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #27.
Calling
wravalwith a--modelvalue that has no matching[<model>]section inconfig/settings.tomlblows up later inget_settings()atsettings.endpoint_typewithAttributeError: 'Settings' object has no attribute 'ENDPOINT_TYPE', because Dynaconf silently loads nothing for the missing env and the default values never get attached.This adds a small preflight check that validates
modelagainst the section names actually present insettings.tomlbefore Dynaconf is instantiated, and raises aValueErrorlisting the available models so the user can see what they typed wrong.What changed
src/wraval/main.py: extracted the settings file path to a module constant, added_known_models()(regex oversettings.tomlfor section headers, ignoring[default]), and added a case-insensitive validation step insideget_settings()that matches the Dynaconfcase_sensitive=Falsesemantics introduced in Add case_insensitive=False to Dynaconf instantiation #28.reonly.Behavior
Before:
After:
Test plan
Repo currently has no test suite. Verified manually that:
haiku-3)defaultis accepted explicitlyHaiku-3,HAIKU-3)ValueErrorwith the full list of available sectionsValueError