Skip to content

fix(element-selector): align selector primitives with tests#1788

Merged
jxiwang merged 1 commit into
jessewang/sr-4608-element-selector-primitives-types-pattern-packs-helpersfrom
cursor/fix-element-selector-tests-b3c4
Jun 2, 2026
Merged

fix(element-selector): align selector primitives with tests#1788
jxiwang merged 1 commit into
jessewang/sr-4608-element-selector-primitives-types-pattern-packs-helpersfrom
cursor/fix-element-selector-tests-b3c4

Conversation

@jxiwang
Copy link
Copy Markdown
Collaborator

@jxiwang jxiwang commented Jun 2, 2026

Summary

Fix element-selector test failures by:

  • matching Radix-generated IDs that use the radix- prefix without a React useId suffix
  • matching common CSS Modules classes with shorter local names, such as Button_root__abc123
  • adding a CSS identifier escape fallback for runtimes without CSS.escape, including jsdom

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: No
Open in Web Open in Cursor 

@jxiwang jxiwang marked this pull request as ready for review June 2, 2026 23:08
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 2, 2026

size-limit report 📦

Path Size
packages/analytics-browser/lib/scripts/amplitude-min.js.gz 58.38 KB (0%)
packages/session-replay-browser/lib/scripts/session-replay-browser-min.js.gz 132.01 KB (0%)
packages/unified/lib/scripts/amplitude-min.umd.js.gz 209.43 KB (0%)

@jxiwang jxiwang merged commit 9758d21 into jessewang/sr-4608-element-selector-primitives-types-pattern-packs-helpers Jun 2, 2026
12 checks passed
@jxiwang jxiwang deleted the cursor/fix-element-selector-tests-b3c4 branch June 2, 2026 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants