🛡️ Sentinel: [Critical] Fix RCE and DoS vulnerabilities in PDF compilation#356
🛡️ Sentinel: [Critical] Fix RCE and DoS vulnerabilities in PDF compilation#356anchapin wants to merge 1 commit into
Conversation
…ation Added `-no-shell-escape` flags and 30-second timeouts to `pdflatex` and `pandoc` compilation subprocesses in `cli/pdf/converter.py` and `cli/generators/cover_letter_generator.py` to prevent Remote Code Execution and Denial of Service attacks via untrusted LaTeX. Co-authored-by: anchapin <6326294+anchapin@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
1 participant
🚨 Severity: CRITICAL
💡 Vulnerability: The application executed LaTeX compilation commands (
pdflatexandpandocviasubprocess.Popen) without restricting shell escapes (-no-shell-escape) and without enforcing a timeout.🎯 Impact: This allowed malicious LaTeX code (e.g., via
\write18) to execute arbitrary commands (RCE) and could cause infinite compilation loops (DoS), locking up server resources.🔧 Fix: Added
-no-shell-escapeflags topdflatexand--pdf-engine-opt=-no-shell-escapetopandoc. Implemented a 30-second timeout with proper process cleanup (process.kill()) for all compilation subprocesses.✅ Verification: Run
python -m pytest tests/test_pdf_security.pyto verify the flags and timeouts are correctly handled.PR created automatically by Jules for task 9562649690067762665 started by @anchapin