🛡️ Sentinel: [Critical] Fix PDF compilation RCE and DoS vulnerabilities#358
🛡️ Sentinel: [Critical] Fix PDF compilation RCE and DoS vulnerabilities#358anchapin wants to merge 1 commit into
Conversation
Enforces the `-no-shell-escape` flag for `pdflatex` and `pandoc` PDF compilation commands in `cli/pdf/converter.py` and `cli/generators/cover_letter_generator.py` to prevent Remote Code Execution (RCE). Also introduces a 30-second timeout with proper subprocess cleanup (`process.kill()`) for `process.communicate()` to prevent Denial of Service (DoS) attacks caused by hanging compilations. Co-authored-by: anchapin <6326294+anchapin@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
1 participant
🚨 Severity: CRITICAL
💡 Vulnerability: PDF compilation using
pdflatexandpandoclacked-no-shell-escapeflags, allowing potential Remote Code Execution (RCE) via malicious LaTeX input. Furthermore,process.communicate()lacked timeouts, allowing for potential Denial of Service (DoS) attacks if the process hung.🎯 Impact: Attackers could execute arbitrary shell commands on the server or cause resource exhaustion by hanging the application indefinitely during PDF generation.
🔧 Fix: Added
-no-shell-escape(and--pdf-engine-opt=-no-shell-escapeforpandoc) to all compilation calls incli/pdf/converter.pyandcli/generators/cover_letter_generator.py. Implemented a 30-second timeout with proper cleanup (process.kill()) and fallback logic.✅ Verification: Ran
python -m pytest tests/test_pdf_security.pyand the full test suite. Verified code review approval.PR created automatically by Jules for task 3913732486244181178 started by @anchapin