🛡️ Sentinel: [CRITICAL] Fix RCE and DoS in scattered LaTeX Compilations#360
🛡️ Sentinel: [CRITICAL] Fix RCE and DoS in scattered LaTeX Compilations#360anchapin wants to merge 2 commits into
Conversation
Added strict security parameters (`-no-shell-escape` flags and 30-second timeouts) to instances in `cli/pdf/converter.py` and `cli/generators/cover_letter_generator.py` that execute `pdflatex` or `pandoc` compilations as subprocesses to prevent RCE and zombie processes. Co-authored-by: anchapin <6326294+anchapin@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
…ns and apply proper code formatting Added strict security parameters (`-no-shell-escape` flags and 30-second timeouts) to instances in `cli/pdf/converter.py` and `cli/generators/cover_letter_generator.py` that execute `pdflatex` or `pandoc` compilations as subprocesses to prevent RCE and zombie processes. Also fixed black code formatting issues causing CI failures. Co-authored-by: anchapin <6326294+anchapin@users.noreply.github.com>
1 participant
🚨 Severity: CRITICAL
💡 Vulnerability: Scattered
pdflatexandpandoccompilations (cli/pdf/converter.py,cli/generators/cover_letter_generator.py) lacked-no-shell-escapeflags and explicit timeouts.🎯 Impact: Allowed untrusted input with LaTeX control characters to execute commands on the machine (RCE), or lock up the application due to infinite compilation loops (DoS / zombie processes).
🔧 Fix: Enforced
-no-shell-escapedirectly topdflatexcommands and via--pdf-engine-opt=-no-shell-escapetopandoccommands. Added 30-second timeouts (timeout=30) utilizing Python'ssubprocess.TimeoutExpiredhandling withkill()and a secondarycommunicate()cleanup.✅ Verification: Tests in
tests/test_pdf_security.pyand the mainpytestsuite were passed successfully, proving fixes function without regressions. Updated.jules/sentinel.mdappropriately with learning.PR created automatically by Jules for task 15799039605999439386 started by @anchapin