Upgrade to Ink 1.1.0-alpha05#87
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the ink dependency to version 1.1.0-alpha05 and removes the forcePathRendering parameter from the CanvasStrokeRenderer.create call in DrawingCanvasViewModel.kt. Additionally, it introduces TilingTexture and StampingTexture messages within a new layer oneof field in brush_family.proto. I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
maxmmitchell
marked this pull request as ready for review
July 15, 2026 18:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade to the latest version of Ink as of this PR, and pull over recent updates to
brush_family.protofrom Ink's Github. Most applicable changes from this version increase for Cahier are:CanvasStrokeRenderer.createwhich takesforcePathRenderinghas been marked internal, and is only for cross-package usage within the Ink library -- we should probably be using the mesh renderer here anyway, so I just went ahead and changed that forDrawingCanvasViewModel.