Skip to content

docs: note JDK 17 requirement for Gradle builds#2134

Open
kanav22 wants to merge 2 commits into
android:mainfrom
kanav22:docs/jdk-17-requirement
Open

docs: note JDK 17 requirement for Gradle builds#2134
kanav22 wants to merge 2 commits into
android:mainfrom
kanav22:docs/jdk-17-requirement

Conversation

@kanav22

@kanav22 kanav22 commented Jun 21, 2026

Copy link
Copy Markdown

Summary

Documents that Gradle must run on JDK 17 for this project. Using JDK 11 causes resolution failures for the baseline profile Gradle plugin and other Java-17-targeted dependencies.

Closes #1137

Changes

  • Add a callout under Development Environment in README with Android Studio Gradle JDK setting instructions

Test plan

  • Documentation-only change

Clarifies Android Studio Gradle JDK setting to avoid Java 11
resolution failures with baseline profile plugin dependencies.

Fixes android#1137
@kanav22 kanav22 requested a review from dturner as a code owner June 21, 2026 20:52

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the README.md to document that JDK 17 is required for Gradle. The feedback suggests using the GitHub-native alert syntax > [!NOTE] instead of > **Note:** to maintain consistency with the rest of the document.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread README.md Outdated
Comment on lines +35 to +38
> **Note:** This project requires **JDK 17** for Gradle. In Android Studio, set
> **Settings → Build, Execution, Deployment → Build Tools → Gradle → Gradle JDK** to **17**
> (or **Embedded JDK** on recent Studio versions). Using JDK 11 will fail when resolving
> the baseline profile Gradle plugin and other dependencies that target Java 17.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with the rest of the document (e.g., lines 123, 147, and 189), use the GitHub-native alert syntax > [!NOTE] instead of > **Note:**.

Suggested change
> **Note:** This project requires **JDK 17** for Gradle. In Android Studio, set
> **Settings → Build, Execution, Deployment → Build Tools → Gradle → Gradle JDK** to **17**
> (or **Embedded JDK** on recent Studio versions). Using JDK 11 will fail when resolving
> the baseline profile Gradle plugin and other dependencies that target Java 17.
> [!NOTE]
> This project requires **JDK 17** for Gradle. In Android Studio, set
> **Settings → Build, Execution, Deployment → Build Tools → Gradle → Gradle JDK** to **17**
> (or **Embedded JDK** on recent Studio versions). Using JDK 11 will fail when resolving
> the baseline profile Gradle plugin and other dependencies that target Java 17.

Aligns with existing README alert blocks for consistency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Documentation]: missing note that Gradle's JDK must be 17

1 participant