Don't override parsed values with other values#21
Merged
Conversation
alistair23
force-pushed
the
alistair/dict-fixup
branch
2 times, most recently
from
2fd83d8 to
c5b3cda
Compare
If ttn_parse() returns an empty results let's skip it, otherwise we can end up overwritting data with an empty packet if multiple packets have been sent. Signed-off-by: Alistair Francis <alistair@alistair23.me>
alistair23
force-pushed
the
alistair/dict-fixup
branch
2 times, most recently
from
5b27924 to
b38fadb
Compare
OR together all of the results of ttn_parse() so that we don't miss any data. According to PEP0584 (https://peps.python.org/pep-0584/#specification) the newset value should be used if the value is set multiple times. Signed-off-by: Alistair Francis <alistair@alistair23.me>
Signed-off-by: Alistair Francis <alistair@alistair23.me>
alistair23
force-pushed
the
alistair/dict-fixup
branch
from
b38fadb to
5b0d5d8
Compare
Contributor
Author
|
This hopefully fixes my missing messages issue. As an extra bonus it means that some of the recent values are added after a reboot, so not every single entity is "Unavailable" after a reboot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If processing multiple packets only the last packet gets kept. This ensures that we process all of the packets.
According to PEP0584 the newset value should be used if the value is set multiple times.