Remove blockers that cause 1-start branch ngrx to fail for Angular 13+ users #36
Open
Nmuta wants to merge 2 commits into
Open
Remove blockers that cause 1-start branch ngrx to fail for Angular 13+ users #36Nmuta wants to merge 2 commits into
Nmuta wants to merge 2 commits into
Conversation
The hard coded ngrx entries in the package.json in the 1-start branch were creating conflicts for Angular 13 + users . Deleting them and then having people reinstall them manually appears to be the best solution. Users will have to manually do :
ng add @ngrx/store
ng add @ngrx/router-store
ng add @ngrx/effects
ng add @ngrx/data
ng add @ngrx/store-devtools
Nmuta
changed the title
Nmuta
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Angular 13+ users, there have been issues with the 1-start branch.
the ng add @ngrx/store
trying ng add @ngrx/store@latest will not work either.
➜ ngrx-course git:(1-start) ✗ ng add @ngrx/store
leads to these types of errors:
"An unhandled exception occurred: NOT SUPPORTED: keyword "id", use "$id" for schema ID" when executing "ng add @ngrx/store".
"ng add @ngrx/store@latest" works for some users but not all.
The key issue appears to be that @ngrx is hard coded in the 1-start branch package.json. I removed all ngrx entries and then added some lines to the README to prompt the user to install all of these dependencies manually:
My pull request essentially sets users up for success to install the newer version of @ngrx in Angular 13+ to help avoid dependency conflicts specifically on the 1-start branch.