fix(@angular/build): prevent externalizing builder-injected i18n locale data#33523
Open
clydin wants to merge 1 commit into
Open
fix(@angular/build): prevent externalizing builder-injected i18n locale data#33523clydin wants to merge 1 commit into
clydin wants to merge 1 commit into
Conversation
…le data When a user externalizes `@angular/common` using the `externalDependencies` option, esbuild's wildcard external rule also marks any paths under `@angular/common/*` as external. This causes the builder-injected locale data imports (`@angular/common/locales/global/<code>`) inside the polyfills bundle to be externalized as bare imports, which fails at runtime because these files are not emitted as standalone public assets.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request ensures that builder-injected i18n locale-data imports are not externalized, even when @angular/common is marked as an external dependency. It updates execute-build.ts to prevent externalizing dependencies starting with LOCALE_DATA_BASE_MODULE, refactors i18n-locale-plugin.ts to use createProjectResolver instead of createRequire to resolve locale paths locally, and adds a new integration test to verify this behavior. There are no review comments, so I have no feedback to provide.
1 task
clydin
added
the
action: review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a user externalizes
@angular/commonusing theexternalDependenciesoption, esbuild's wildcard external rule also marks any paths under@angular/common/*as external.This causes the builder-injected locale data imports (
@angular/common/locales/global/<code>) inside the polyfills bundle to be externalized as bare imports, which fails at runtime because these files are not emitted as standalone public assets.