Skip to content

build: update dependency sass_api to v17.5.0#3587

Merged
josephperrott merged 1 commit intoangular:mainfrom
angular-robot:ng-renovate/sass-api-17-x
Apr 3, 2026
Merged

build: update dependency sass_api to v17.5.0#3587
josephperrott merged 1 commit intoangular:mainfrom
angular-robot:ng-renovate/sass-api-17-x

Conversation

@angular-robot
Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Type Update Change
sass_api dependencies minor 17.4.017.5.0

  • If you want to rebase/retry this PR, check this box

See associated pull request for more information.
@angular-robot angular-robot added action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: automation This PR is targeted to only merge into the branch defined in Github [bot use only] labels Apr 3, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the sass and sass_api dependencies to versions 1.99.0 and 17.5.0, respectively. The feedback suggests using caret syntax for the sass_api dependency in pubspec.yaml to follow Dart best practices and maintain consistency with other dependencies in the project.

# Add regular dependencies here.
dependencies:
sass_api: 17.4.0
sass_api: 17.5.0
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The sass_api dependency is pinned to an exact version, which is inconsistent with other dependencies in this file (like sprintf) that use caret syntax (^). In Dart, it is generally recommended to use semantic versioning ranges (e.g., ^17.5.0) in pubspec.yaml to allow for compatible patch and minor updates, while relying on pubspec.lock to ensure exact version pinning for reproducibility. This also helps avoid potential version solving conflicts for consumers of this package.

  sass_api: ^17.5.0

Copy link
Copy Markdown
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott merged commit 5dac376 into angular:main Apr 3, 2026
13 checks passed
@josephperrott
Copy link
Copy Markdown
Member

This PR was merged into the repository. The changes were merged into the following branches:

@angular-robot angular-robot deleted the ng-renovate/sass-api-17-x branch April 3, 2026 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: automation This PR is targeted to only merge into the branch defined in Github [bot use only]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants