Skip to content

refactor: move pnpm cache configuration from setup-node to pnpm actio…#3658

Merged
alan-agius4 merged 1 commit into
angular:mainfrom
alan-agius4:cache-use-pnpm
May 12, 2026
Merged

refactor: move pnpm cache configuration from setup-node to pnpm actio…#3658
alan-agius4 merged 1 commit into
angular:mainfrom
alan-agius4:cache-use-pnpm

Conversation

@alan-agius4
Copy link
Copy Markdown
Contributor

…n-setup

Use pnpm setup to cache store.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the caching configuration from the actions/setup-node step to the pnpm/action-setup step within the checkout-and-setup-node composite action. A review comment correctly identifies a naming error where cache_dependency_path was used instead of the expected hyphenated cache-dependency-path, which would cause the input to be ignored by the action.

Comment thread github-actions/npm/checkout-and-setup-node/action.yml
Copy link
Copy Markdown
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label May 12, 2026
@alan-agius4 alan-agius4 merged commit 70e6118 into angular:main May 12, 2026
12 checks passed
@alan-agius4
Copy link
Copy Markdown
Contributor Author

This PR was merged into the repository. The changes were merged into the following branches:

@alan-agius4 alan-agius4 deleted the cache-use-pnpm branch May 12, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants