Skip to content

fix(ng-dev/release): make package deprecation errors non-fatal #3660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josephperrott merged 2 commits into from
May 12, 2026
+10 −1
Merged

fix(ng-dev/release): make package deprecation errors non-fatal #3660

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0fb2e9c
fix(ng-dev/release): make package deprecation errors non-fatal
alan-agius4 May 12, 2026
28c12b2
fixup! fix(ng-dev/release): make package deprecation errors non-fatal
alan-agius4 May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion ng-dev/release/versioning/npm-command.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import semver from 'semver';
import {ChildProcess} from '../../utils/child-process.js';

import {NpmDistTag} from './npm-registry.js';
import {Log} from '../../utils/logging.js';

export abstract class NpmCommand {
/**
Expand Down Expand Up @@ -47,7 +48,15 @@ export abstract class NpmCommand {
args.push('--registry', registryUrl);
}

await ChildProcess.spawn('npm', args, {mode: 'silent'});
try {
await ChildProcess.spawn('npm', args, {mode: 'silent'});
} catch (e) {
// TODO(alanagius): remove try/catch block once https://buganizer.corp.google.com/u/1/issues/512428441 is fixed.
Log.error(Array(80).join('#'));
Log.error(` ✘ An error occurred while deprecating "${packageName}".`);
Comment thread
alan-agius4 marked this conversation as resolved.
Log.error(e);
Log.error(Array(80).join('#'));
}
}

/**
Expand Down
Loading