feat(ng-dev/pr): support auto-merging pull requests once pending status checks pass#3661
Open
josephperrott wants to merge 1 commit into
Open
feat(ng-dev/pr): support auto-merging pull requests once pending status checks pass#3661josephperrott wants to merge 1 commit into
josephperrott wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a mechanism to wait for pending pull request validations before merging, adding a new --wait-for-validations CLI flag and a polling loop that re-fetches PR data. The implementation includes an isFinal property for validation failures to distinguish between transient and permanent issues. Feedback was provided to optimize the waiting logic; currently, the tool waits for pending validations even if final failures (like a rejected review) are already present. It is suggested to only trigger the wait loop if all current failures are non-final to prevent unnecessary delays.
josephperrott
force-pushed
the
wait-on-validation
branch
from
a9a6e64 to
19d73ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables the ng-dev pr merge command to wait on non-final pending status validations (such as running CI workflows) to complete rather than aborting immediately. Includes interactive progress feedback and bounded timeout handling.