Simplify HashUtil method when possible#12307
Closed
Arthur-Milchior wants to merge 2 commits into
Closed
Conversation
Member
|
Needs a rebase to remove the |
david-allison
added
the
Needs Author Reply
Arthur-Milchior
force-pushed
the
capacity
branch
from
4740b9e to
4959a81
Compare
Member
|
@Arthur-Milchior Build failure:
|
Arthur-Milchior
force-pushed
the
capacity
branch
from
4959a81 to
2f4b5f7
Compare
* Move out of object. * transform as an expression * uses coerceAtLeast as suggested by IDE * Generalize some value it returns to Kotlin interface instead of specific kind of set/map
The function generate set and map from collections already deals with doing proper size allocation.
Arthur-Milchior
force-pushed
the
capacity
branch
from
2f4b5f7 to
1ea8e24
Compare
Contributor
|
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed automatically |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that HashUtil methods are not used in Java anymore (at least once #12301 is merged. But my two commits can be reviewed independently of #12301), I can make them return Kotlin type instead of java type. This ensure better typing as far as nullability goes.
Working on them, I also cleaned every usage of those methods that can be replaced by map/associate/filter.
I believe this PR should be rebased