Remove config for JavaCompile in gradle#12431
Merged
Merged
Conversation
mikehardy
approved these changes
Sep 17, 2022
mikehardy
left a comment
mikehardy
left a comment
Member
There was a problem hiding this comment.
Just checking - if you use a deprecated kotlin api, it is flagged as error on build still?
Member
Author
|
@mikehardy Yeah, already verified that. |
ShridharGoel
added
the
Needs Second Approval
Member
|
Great - let's go for it |
github-actions
Bot
removed
the
Needs Second Approval
Member
|
Thanks! Hopefully a compile speed improvement as well Link as this is a follow up: #12312 |
Member
Author
|
@mikehardy Yeah, I had verified that.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we have completely shifted to Kotlin, this can be removed from build.gradle.