Skip to content

[Multiple-Profile]feat: add profile dialog#20654

Open
criticalAY wants to merge 1 commit intoankidroid:mainfrom
criticalAY:mp/add-profile-dialog
Open

[Multiple-Profile]feat: add profile dialog#20654
criticalAY wants to merge 1 commit intoankidroid:mainfrom
criticalAY:mp/add-profile-dialog

Conversation

@criticalAY
Copy link
Copy Markdown
Contributor

Purpose / Description

Add the dialog in multi profile fragment allowing to add profile, basically dialog implementation

Fixes

Approach

NA

How Has This Been Tested?

Pixel 10:
image

Learning (optional, can help others)

NA

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@criticalAY criticalAY changed the title feat: add profile dialog [Multiple-Profile]feat: add profile dialog Apr 5, 2026
Copy link
Copy Markdown
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementer's choice

@david-allison david-allison added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Apr 5, 2026
@criticalAY criticalAY force-pushed the mp/add-profile-dialog branch from 4abb206 to a2b07ec Compare April 5, 2026 17:46
@ZornHadNoChoice
Copy link
Copy Markdown
Collaborator

I suggest using the "Name" string used in similar dialogs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Second Approval Has one approval, one more approval to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants