Fix improve the review ahead refactor#20678
Open
Galal-20 wants to merge 11 commits intoankidroid:mainfrom
Open
Fix improve the review ahead refactor#20678Galal-20 wants to merge 11 commits intoankidroid:mainfrom
Galal-20 wants to merge 11 commits intoankidroid:mainfrom
Conversation
- Add a title "Review ahead". - Change the description with "Review cards due in the next:". - Added a unit "day"/"days" to the box. - Change "OK" with "Create". - Show a warning when the input is invalid, limit the digits, and prevent leading zeros.
…"1") while still preventing leading zeros in other cases. fix: Code Enhancement
- Improve the comments by add a comment for documentation and remove unnecessary comments. - Update limit prevent excessively long numeric input.
- Unit test added.
Contributor
|
Important Maintainers: This PR contains Strings changes
|
Contributor
Author
|
Hello @david-allison, |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
This PR improves the Review Ahead dialog UX to align with expected behavior and consistency
Additionally, the query construction has been refactored and clarified based on Anki's search syntax (deck + prop:due), which is used across Anki Desktop and backend.
Fixes
Fixes: #20600
Approach
The following improvements were implemented:
UI Enhancements:
Input Validation Improvements:
ْUnit Tests:
How Has This Been Tested?
Tested manually on:
Android Emulator (API 33) and Physical device
Test Cases:
Screenshots
some screens:




Reference:
https://docs.ankiweb.net/searching.html
Checklist
Please, go through these checks before submitting the PR.