Remove 3rd party gradle wrapper update#20742
Merged
mikehardy merged 1 commit intoankidroid:dependency-updatesfrom Apr 15, 2026
Merged
Remove 3rd party gradle wrapper update#20742mikehardy merged 1 commit intoankidroid:dependency-updatesfrom
mikehardy merged 1 commit intoankidroid:dependency-updatesfrom
Conversation
Member
|
|
Member
Author
|
Huh - lemme check that - can obviously back it down to 2.3.10 as needed - just want to fish out the actual dependency-updates commit where that happened |
5 tasks
Member
Author
|
re-running codeql still pulls v2.25.1, 2.25.2 is the one with the fix 🤷 |
Member
Author
|
there's no way the codeql change will affect this so going to merge, then CI on dependency updates will run and it should go green |
d68bb17
into
ankidroid:dependency-updates
38 of 41 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Purpose / Description
Noticed semi-recently that dependabot started handling gradle wrapper updates well
We have been relying on a third party action (and special workflow to run it) in order to update the wrapper historically
It appears that is no longer necessar
Fixes
Approach
Just nuke the file
How Has This Been Tested?
dependabot tested it in practice by proposing the correct change with no changes to it's config
Learning (optional, can help others)
Checklist
Please, go through these checks before submitting the PR.