Skip to content

Remove 3rd party gradle wrapper update#20742

Merged
mikehardy merged 1 commit intoankidroid:dependency-updatesfrom
mikehardy:remove-3rd-party-gradle-wrapper-update
Apr 15, 2026
Merged

Remove 3rd party gradle wrapper update#20742
mikehardy merged 1 commit intoankidroid:dependency-updatesfrom
mikehardy:remove-3rd-party-gradle-wrapper-update

Conversation

@mikehardy
Copy link
Copy Markdown
Member

Purpose / Description

Noticed semi-recently that dependabot started handling gradle wrapper updates well

We have been relying on a third party action (and special workflow to run it) in order to update the wrapper historically

It appears that is no longer necessar

Fixes

Approach

Just nuke the file

How Has This Been Tested?

dependabot tested it in practice by proposing the correct change with no changes to it's config

Learning (optional, can help others)

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@mikehardy mikehardy changed the base branch from main to dependency-updates April 14, 2026 16:08
@mikehardy mikehardy requested a review from david-allison April 14, 2026 16:08
@mikehardy mikehardy added CI dependencies used for automated dependency PRs labels Apr 14, 2026
@david-allison
Copy link
Copy Markdown
Member

vbpd; common; api apparently all now compiling with Kotlin 2.3.20

-----------
* What went wrong:
Execution failed for task ':vbpd:compileReleaseKotlin'.
> A failure occurred while executing org.jetbrains.kotlin.compilerRunner.btapi.BuildToolsApiCompilationWork
   > Kotlin version 2.3.20 is too recent. CodeQL currently supports versions below 2.3.20

==============================================================================

2: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':common:compileReleaseKotlin'.
> A failure occurred while executing org.jetbrains.kotlin.compilerRunner.btapi.BuildToolsApiCompilationWork
   > Kotlin version 2.3.20 is too recent. CodeQL currently supports versions below 2.3.20

3: Task failed with an exception.

-----------
Deprecated Gradle features were used in this build, making it incompatible with Gradle 10.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

For more on this, please refer to https://docs.gradle.org/9.4.1/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.
56 actionable tasks: 44 executed, 12 from cache
* What went wrong:
Execution failed for task ':api:compileReleaseKotlin'.
> A failure occurred while executing org.jetbrains.kotlin.compilerRunner.btapi.BuildToolsApiCompilationWork
   > Kotlin version 2.3.20 is too recent. CodeQL currently supports versions below 2.3.20

@mikehardy
Copy link
Copy Markdown
Member Author

Huh - lemme check that - can obviously back it down to 2.3.10 as needed - just want to fish out the actual dependency-updates commit where that happened

@david-allison
Copy link
Copy Markdown
Member

david-allison commented Apr 15, 2026

@mikehardy
Copy link
Copy Markdown
Member Author

re-running CI, codeql may support 2.3.20 as of today

github/codeql#21484 (comment)

image

@mikehardy mikehardy closed this Apr 15, 2026
@mikehardy mikehardy reopened this Apr 15, 2026
@mikehardy
Copy link
Copy Markdown
Member Author

re-running codeql still pulls v2.25.1, 2.25.2 is the one with the fix 🤷

@mikehardy
Copy link
Copy Markdown
Member Author

there's no way the codeql change will affect this so going to merge, then CI on dependency updates will run and it should go green

@mikehardy mikehardy merged commit d68bb17 into ankidroid:dependency-updates Apr 15, 2026
38 of 41 checks passed
@github-actions github-actions bot added this to the 2.24 release milestone Apr 15, 2026
@mikehardy mikehardy deleted the remove-3rd-party-gradle-wrapper-update branch April 15, 2026 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI dependencies used for automated dependency PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants