Csv import: Refactorings & CsvMapping class

[david-allison]

Pull Request template

Purpose / Description

This breaks off a few changes from #9437 for the CSV import

How Has This Been Tested?

The main change was tested, this should purely be adding code, tested bugfixes and nonfunctional refactorings

Learning (optional, can help others)

I'm unlikely to going to get a large change in in a single PR, and it's better to break it down, despite feeling it's readable as-is

Checklist

• You have not changed whitespace unnecessarily (it makes diffs hard to read)
• You have a descriptive commit message with a short title (first line, max 50 chars).
• Your code follows the style of the project (e.g. never omit braces in if statements)
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• UI Changes: You have tested your change using the Google Accessibility Scanner

[mikehardy]

lint check is possibly a remnant as you teased the commits apart?

Lint found 2 errors. First failure:
Fix the issues identified by lint, or add the following to your build script to proceed with errors:
/home/runner/work/Anki-Android/Anki-Android/AnkiDroid/src/main/res/drawable/edit_text_color_enabled_selector.xml:20: Error: The resource R.drawable.edit_text_color_enabled_selector appears to be unused [UnusedResources]
...

[mikehardy]

Read through it all - seems okay. I'm a bit unclear on major vs minor changes (dispatched where? who would use those handlers + how do you add them to use the facility? I didn't see it in the test so was just a bit unclear). One method name thought, but otherwise LGTM + want to merge

[david-allison]

I'll add more documentation on the dispatch methods. I'd rather the code spoke for itself than explain it here. Thanks!

[david-allison]

Awaiting re-review (assuming I didn't blow up CI), especially to see if the distinction between major and minor changes has been made more clear.

If not, I'll explain the usages and let's brainstorm some better docs.

[mikehardy]

All LGTM - boom

[mikehardy]

was waiting on this one for a re-sync on I18n now I'll do an alpha with fresh strings and all the merges of the day