fix(relay): pin Chrome Web Store origin - #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Pin production WebSocket access to Chrome Web Store extension ID
gmjpoplfomnnjipeiojccjbpjlodkjhnand bump the Store package to0.0.23.Before / After
Before: any installed Chrome extension could connect to the production relay's extension or browser websocket endpoint.
After: packaged relays accept only the assigned Browser Control Store origin. Source-mode relays retain an explicit permissive path for unpacked extension development and isolated tests.
How
src/relay-helpers.tschrome-extension://origins only whenbrowserControlVersion === "0.0.0-dev"Scope
This does not upgrade the currently running shared relay. The published follow-up should be installed together with the approved Store build so the existing unpacked extension is not disconnected prematurely.
Testing
pnpm run ciartifacts/browser-control-extension-0.0.23.zip982e2fa12d83d5ef54dc976b28ad9fd5341264d7996ae8253a6520ee6dbab869