Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .agents/skills/td-pr-new/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,11 @@ module** surrounding each changed hunk — not just the hunk itself.
function, construct one realistic failure case: an edge-case input,
an empty-but-not-falsy value, a timeout, a concurrent access. Trace
it through the code path. If it fails silently or violates the
declared type, that's a finding.
declared type, that's a finding. Also inspect **test helpers**:
allocation/probe helpers that silently return sentinel values
(port `0`, empty host, `-1`) instead of failing hide infrastructure
errors and cause confusing flakes — prefer fail-fast with an
`error` path and a clear rejection when the result is unusable.

9. **Do inherited contracts hold?** When implementing a Protocol or
extending a base class, check that the subclass honors the full
Expand Down
5 changes: 4 additions & 1 deletion .agents/skills/td-pr-review/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,10 @@ scenarios for public functions: what happens with an empty-but-not-falsy
value, a field combination after partial deletion, a response that
satisfies the HTTP status check but lacks expected fields? If the traced
path fails silently, sends a vacuous request, or produces a return value
that violates the declared type, the reviewer flags it.
that violates the declared type, the reviewer flags it. The same lens
applies to **test helpers**: probes that silently return sentinel values
(e.g. port `0`) instead of failing hide setup errors and produce
confusing flakes — fail-fast with an error handler is required.

**Inherited contract completeness.** When the diff extends a class or
implements a Protocol, the reviewer checks that the subclass honors the
Expand Down
Loading