[codex] Fix Gradle toolchain provisioning#487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes snapshot deployment failing when Gradle needs to resolve the Java 23 Azul toolchain on a clean GitHub Actions runner.
build-logicbuild so its own Java/Kotlin toolchains can be auto-provisioned.updateDaemonJvmto generate daemon JVM criteria for Java 23 with the Azul vendor.gradle/gradle-daemon-jvm.propertiesso daemon auto-provisioning uses Azul download URLs and recordstoolchainVendor=AZUL.Root cause
The snapshot job ran with Java 21 but the build requests a Java 23 Azul toolchain. Gradle could not find that local installation and reported that toolchain download repositories were not configured for that build path.
Validation
./gradlew updateDaemonJvm --no-daemon --stacktraceenv GRADLE_USER_HOME=/private/tmp/auto-dagger-gradle-home ./gradlew publishSnapshot --no-configuration-cache --stacktrace -m -PmavenCentralUsername=dummy -PmavenCentralPassword=dummy./gradlew check --continue --stacktracereached all Kotlin/Android tests and lint, but failed on local:checkPythonbecause the selected local Python has no pip installed.