fix(e2e): opt dev server out of the OTP auth handshake for automation#182
Merged
Conversation
devframe v0.7.5 gates RPC calls behind an interactive one-time-code handshake by default. The e2e dev-mode server has no way to complete that handshake headlessly, so every RPC call (including the initial payload fetch) was rejected with DF0036, failing dev.spec.ts. Add a --auth/--no-auth flag to the dev command (mirroring devframe's own --no-auth convention) and use it from the e2e orchestrator.
commit: |
antfubot
added a commit
to antfubot/node-modules-inspector
that referenced
this pull request
Jul 21, 2026
Merge origin/main (antfu#181 exclude dev dependencies filter, antfu#182 e2e OTP fix, another own-repo module-type test fix) into this branch. - FiltersOptionExcludes.vue: the new "Exclude Dev Dependencies" OptionItem applies the same FormCheckbox treatment (`:div="true"` on OptionItem) as its siblings. - module-type.test.ts: main independently hit and fixed the same h3-became- ESM-only issue (swapping the "dual" fixture to `vue`) — take their fixture choice for consistency with upstream, keep this branch's more robust deterministic (file-relative, not hoist-order-dependent) resolution. `vue` resolves consistently regardless of which installed patch gets hoisted (same dual exports shape across 3.5.x), so no pinned devDependency needed; drop the now-unused tinyglobby one. Verified: vue-tsc --noEmit, eslint, vitest (87/87) and pnpm build all pass; live-checked the new Exclude Dev Dependencies checkbox renders and is positioned correctly. Created with the help of an agent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The full e2e suite (
pnpm test:e2e) fails ontest/e2e/dev.spec.ts— every RPC call the SPA makes against the live dev server (including the initial payload fetch) is rejected:devframe
v0.7.5gates RPC calls behind an interactive one-time-code handshake by default (the dev server prints a code / magic link that a human clicks). A headless Playwright browser has no way to complete that handshake, so the dev-mode tests time out waiting for the nav rail to mount.Fix
--auth/--no-authflag to thenode-modules-inspectordev command, mirroring devframe's own--no-authconvention, and forward it intocreateDevServer'sflagsbag (which is where devframe resolves the auth gate).--no-auth, since it's a trusted, single-purpose process serving only the local Playwright suite.Production
node-modules-inspectordev usage is unaffected — the flag defaults totrue(auth enabled), matching devframe's default.Verification
pnpm test:e2e— 28/28 passing (was 2 failing indev.spec.ts).🤖 Generated with the help of an agent.