fix: improve error message for malformed tool use JSON in streaming#1308
Open
IgnazioDS wants to merge 1 commit intoanthropics:mainfrom
Open
fix: improve error message for malformed tool use JSON in streaming#1308IgnazioDS wants to merge 1 commit intoanthropics:mainfrom
IgnazioDS wants to merge 1 commit intoanthropics:mainfrom
Conversation
Mirror the try-except error handling from _beta_messages.py into _messages.py so that malformed JSON in streaming tool use input produces a helpful error message with the raw JSON content instead of a bare deserialization traceback. Fixes anthropics#1265
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
from_json()in_messages.pyto match the existing pattern in_beta_messages.pyProblem
The non-beta streaming path (
client.messages.stream()) crashes with an unhelpful error when the model produces invalid JSON for tool input. The beta path already handles this gracefully with a descriptive message. See #1265.Test plan
Fixes #1265