Open
Conversation
Signed-off-by: Kamil Rakoczy <krakoczy@antmicro.com>
Member
|
Thanks. It's good to see this implemented in practice. The code did not get shorter :) Here it seems like argparse is actually a fairly good choice. I added typing info which the latest fire can consume and output in the help. But I ran into one serious issue with fire: namely, it will run the function and only then parse the remaining arguments. That is definitely not something I'd expect as a behavior of a CLI parsing library. To include the typing info in the help output we could use fire's master branch (release 0.3.1 does not yet have this feature) but until the command line argument parsing problem is not solved, I think actually argparse serves us better, so I will hold off merging this (even if I asked for it myself!) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change usage of argparse to python-fire.
Fixes #19
Signed-off-by: Kamil Rakoczy krakoczy@antmicro.com