Fix Guardrails.record() dropping tool args for prerequisite tracking#72
Open
hobostay wants to merge 1 commit into
Open
Fix Guardrails.record() dropping tool args for prerequisite tracking#72hobostay wants to merge 1 commit into
hobostay wants to merge 1 commit into
Conversation
Guardrails.record() only passed tool names to StepEnforcer.record(), but StepEnforcer also accepts an optional args parameter used for argument-based prerequisite checks (e.g., "tool B requires tool A to have been called with mode='full'"). Without args, prerequisite checks that depend on argument values always see missing data and produce false negatives. Update the signature to accept both plain tool names (backward compatible) and (name, args) tuples, forwarding args to the enforcer when provided. The runner already passes args correctly — this fix brings the convenience wrapper to parity. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Guardrails.record()only passed tool names toStepEnforcer.record(), butStepEnforceralso accepts an optionalargsparameter for argument-based prerequisite checksmode='full'") always see missing data and produce false negatives(name, args)tuplesImpact
step_enforcer.record(tc.tool, tc.args)) — this fix brings the Guardrails convenience wrapper to parityGuardrails.record()will now properly support argument-based prerequisitesTest plan
(name, args)tuples properly forwards args🤖 Generated with Claude Code