Fix return_diagnostics warning from Kernel.ParallelCompiler on Elixir 1.19+#317
Open
markszabo wants to merge 1 commit into
Open
Fix return_diagnostics warning from Kernel.ParallelCompiler on Elixir 1.19+#317markszabo wants to merge 1 commit into
markszabo wants to merge 1 commit into
Conversation
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running
mix especon Elixir 1.19 prints the following warning on every run, before any specs execute:Elixir 1.19 made
return_diagnostics: truemandatory for callers ofKernel.ParallelCompilerfunctions. Thecompile/2call inlib/mix/tasks/espec.exdoesn't have this, and this PR adds it.Backward compatibility
Safe on all Elixir versions:
return_diagnostics: truewas introduced in 1.15.0 and silently accepted; it was only recommended, not required, so no warning was emittedKernel.ParallelCompiler.compile/2accepts an open keyword list and reads options viaKeyword.get. An unrecognised key is simply never read; no error or warning is raisedThough I only tested it on 1.19.
With
return_diagnostics: truethe third element of the return tuple changes shape, but espec's call-site only pattern-matches on{:error, _, _}and discards the third element, so this has no effect on behavior.