Skip to content

Further rollback change as it seems original is faster #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HavierD merged 1 commit into from
Jun 25, 2025
Merged

Further rollback change as it seems original is faster #135

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions server/src/main/java/au/org/aodn/ogcapi/server/core/parser/stac/GeometryVisitor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,13 +118,14 @@ public Object visit(BBOX filter, Object data) {
if(filter instanceof BBoxImpl<?> impl) {
if(impl.getGeometry() != null && (data instanceof Polygon || data instanceof GeometryCollection)) {
Geometry input = (Geometry) data;
try {
return impl.getGeometry().intersection(input);
}
catch(Exception e) {
// buffer is expensive to fix invalid geometry, call it only if needed
return impl.getGeometry().intersection(input.buffer(0.0));
}
// buffer is expensive but turns out it is faster in most case by doing it instead of using try catch
// try {
// return impl.getGeometry().intersection(input);
// }
// catch(Exception e) {
// return impl.getGeometry().intersection(input.buffer(0.0));
//}
return impl.getGeometry().intersection(input.buffer(0.0));
}
else {
return data;
Expand Down