Add run_after to TriggerDagRunOperator#62259
Conversation
a33dfeb to
8e7c84d
Compare
3d40250 to
fedde25
Compare
jason810496
left a comment
There was a problem hiding this comment.
Thanks for the PR! LGTM overall.
|
@arnoldmr01 Converting to draft — this PR doesn't yet meet our Pull Request quality criteria.
See the linked criteria for how to fix each item, then mark the PR "Ready for review". This is not a rejection — just an invitation to bring the PR up to standard. No rush. Note: This comment was drafted by an AI-assisted triage tool and may contain mistakes. Once you have addressed the points above, an Apache Airflow maintainer — a real person — will take the next look at your PR. We use this two-stage triage process so that our maintainers' limited time is spent where it matters most: the conversation with you. |
4a4a78f to
94c8910
Compare
0cd218e to
d598e1e
Compare
d598e1e to
0dbf468
Compare
jason810496
left a comment
There was a problem hiding this comment.
Thanks for the update, LGTM!
Please resolve the conflict when you have a moment, then we can merge the PR.
|
@arnoldmr01 Converting to draft — this PR doesn't yet meet our Pull Request quality criteria.
See the linked criteria for how to fix each item, then mark the PR "Ready for review". This is not a rejection — just an invitation to bring the PR up to standard. No rush. Note: This comment was drafted by an AI-assisted triage tool and may contain mistakes. Once you have addressed the points above, an Apache Airflow maintainer — a real person — will take the next look at your PR. We use this two-stage triage process so that our maintainers' limited time is spent where it matters most: the conversation with you. |
bb362a1 to
90d68b7
Compare
feat: add support to TriggerDagRunOperator
bb5760a to
13d03d4
Compare
13d03d4 to
c5f640a
Compare
|
Might be unrelated CI failure |
|
@arnoldmr01 Sorry, I just realized this PR already existed — I independently implemented the same run_after threading as part of #65856 (commit 82c130f). Besides Airflow 2 compat, there are mainly some differences in default value handling. Would you mind taking a look? |
|
@arnoldmr01 — There are 1 unresolved review thread on this PR from @jason810496. Could you either push a fix or reply in each thread explaining why the feedback doesn't apply? Once you believe the feedback is addressed, mark the thread as resolved so the reviewer isn't re-pinged needlessly. Thanks! Note: This comment was drafted by an AI-assisted triage tool and may contain mistakes. Once you have addressed the points above, an Apache Airflow maintainer — a real person — will take the next look at your PR. We use this two-stage triage process so that our maintainers' limited time is spent where it matters most: the conversation with you. |
|
Thanks @arnoldmr01 for focusing on this. Nice feature. |
* feat: add run_after to DagRunTriggerException * feat: add support to TriggerDagRunOperator feat: add support to TriggerDagRunOperator * feat: add run_after to TriggerDagRunPayload * feat: add run_after support to task_runner and supervisor * feat: Add _validate_datetime_param * feat: Add _parse_datetime_param * feat: add versioning for TriggerDagRunPayload * fix: add overload to _parse and _validate def * test: update unit test * fix: import is_arg_set * chore: typo modification * fix: fix unit test * fix: fix static check * feat: Add comment for unsupported attrs in AF2 --------- Co-authored-by: Arnold Lin <arnoldmr01@Arnolds-MacBook-Air.local>
Why
To let TriggerDagRunOperator support run_after parameter in order to trigger multiple DagRuns of the same DAG in parallel without being constrained by logical_date.
What does the PR change
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.