-
Notifications
You must be signed in to change notification settings - Fork 17.1k
AIP-103: Adding periodic task state garbage collection and retention support #66463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
amoghrajesh
merged 12 commits into
apache:main
from
astronomer:aip-103-4-garbage-collection-and-cleanup
May 14, 2026
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
b644ce6
AIP-103: Adding periodic task state garbage collection and retention …
amoghrajesh cdc4237
comments from jason
amoghrajesh df379c5
handling comments from ash
amoghrajesh 7f401d4
Merge branch 'main' into aip-103-4-garbage-collection-and-cleanup
amoghrajesh f52ce27
comment from TP
amoghrajesh 7427d04
comment from wei
amoghrajesh 151dee5
Update airflow-core/src/airflow/state/metastore.py
amoghrajesh 66081d0
fixing tests and static checks
amoghrajesh 58dba88
fixing tests
amoghrajesh 6b6968e
comment from wei
amoghrajesh 77450e5
last set of comments from wei
amoghrajesh 2a21b7d
Merge branch 'main' into aip-103-4-garbage-collection-and-cleanup
amoghrajesh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
49 changes: 49 additions & 0 deletions
49
airflow-core/src/airflow/cli/commands/state_store_command.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
| from __future__ import annotations | ||
|
|
||
| import logging | ||
|
|
||
| from airflow.state import get_state_backend | ||
| from airflow.state.metastore import MetastoreStateBackend | ||
|
|
||
| log = logging.getLogger(__name__) | ||
|
|
||
| # Other state operations (list, get, delete per key) will be added here in the future. | ||
|
|
||
|
|
||
| def cleanup_task_states(args) -> None: | ||
| """Remove expired task state rows (MetastoreStateBackend only).""" | ||
| backend = get_state_backend() | ||
|
|
||
| if not isinstance(backend, MetastoreStateBackend): | ||
| print("Custom backend configured — skipping cleanup (not supported).") | ||
| return | ||
|
|
||
| if args.dry_run: | ||
| summary = backend._summary_dry_run() | ||
| expired = summary["expired"] | ||
| if not expired: | ||
| print("Nothing to delete.") | ||
| return | ||
| print(f"Would delete {len(expired)} task state row(s):\n") | ||
| for dag_id, run_id, task_id, map_index, key in expired: | ||
| print(f" Dag {dag_id!r}, run {run_id!r}, task {task_id!r}, map_index {map_index!r}, key {key!r}") | ||
| return | ||
|
|
||
| log.info("Running task state cleanup") | ||
| backend.cleanup() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.