Migrate Exasol provider to pyexasol 2.x#69695
Open
joshuabvarghese wants to merge 3 commits into
Open
Conversation
joshuabvarghese
marked this pull request as ready for review
July 10, 2026 07:28
potiuk
added
the
ready for maintainer review
Contributor
|
Quickest fix: git fetch upstream main && git rebase upstream/main
rm uv.lock && uv lock
git add uv.lock && git rebase --continue
git push --force-with-leaseAutomated nudge — ignore if you're not ready to rebase. This comment is updated in place on future |
joshuabvarghese
requested review from
Lee-W,
amoghrajesh,
ashb,
bolkedebruin,
bugraoz93,
choo121600,
dabla,
dheerajturaga,
dstandish,
eladkal,
ephraimbuddy,
gopidesupavan,
hussein-awala,
jason810496,
jedcunningham,
jscheffl,
kaxil,
mobuchowski,
o-nikolas,
potiuk,
shahar1,
uranusjr,
vatsrahul1001 and
vincbeck
as code owners
July 16, 2026 10:01
joshuabvarghese
requested review from
XD-DENG,
bbovenzi,
guan404ming,
henry3260,
pierrejeambrun,
rawwar,
romsharon98,
ryanahamilton and
shubhamraj-git
as code owners
July 16, 2026 10:01
joshuabvarghese
force-pushed
the
migrate-exasol-pyexasol2
branch
2 times, most recently
from
July 16, 2026 10:36
7167ae9 to
bd428aa
Compare
joshuabvarghese
force-pushed
the
migrate-exasol-pyexasol2
branch
from
July 16, 2026 10:44
bd428aa to
612378a
Compare
eladkal
reviewed
Jul 16, 2026
Comment on lines
+30
to
+48
| Breaking changes | ||
| ~~~~~~~~~~~~~~~~ | ||
|
|
||
| * ``Migrate exasol provider to pyexasol 2.x; remove the <2 cap (#69123)`` | ||
|
|
||
| This provider now requires ``pyexasol>=2.0.0,<3``. pyexasol 2.0.0 ships a ``py.typed`` marker | ||
| (`pyexasol changelog <https://exasol.github.io/pyexasol/master/changes/changes_2.html>`__), which | ||
| surfaces several previously-hidden type mismatches in the Exasol hook: | ||
|
|
||
| * ``ExasolHook.get_records()`` and ``ExasolHook.get_first()`` now only accept a single SQL string, | ||
| not a list of statements (pyexasol's underlying ``execute()`` never actually supported a list; use | ||
| ``ExasolHook.run()`` for executing multiple statements in sequence). | ||
| * ``parameters``/``query_params`` passed to ``get_records()``, ``get_first()``, ``run()``, and | ||
| ``get_df()``/``get_pandas_df()`` must be a ``dict``/``Mapping``. Positional-style parameters | ||
| (lists/tuples) were never actually supported by pyexasol at runtime and will now raise a clear | ||
| ``TypeError`` instead of failing deep inside pyexasol (or silently doing the wrong thing). | ||
| * If you pass ``export_params={"with_column_names": ...}`` to ``ExasolHook.export_to_file()`` or | ||
| ``ExasolToS3Operator``, note that pyexasol 2.0.0 fixed this option to be interpreted as a real | ||
| boolean; previously any value (including ``False``) was treated as ``True``. |
Contributor
There was a problem hiding this comment.
The list note stuff but nothing here strike as airflow breaking change is it?
Can you just remove the breaking changes title?
also, did you validate these statements? This feels AI generated. Please provide evidences that the points here are valid. Just referencing to the upstream docs/code should be enough
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR upgrades the Exasol provider to support
pyexasolversion 2.x.As
pyexasol2.x introduces changes to the underlying library API, this PR includes the necessary refactoring of the Exasol hook, updates to the unit tests, and adjustments to the provider's dependencies and documentation to maintain full compatibility.Key Changes:
ConnectionfromExaConnectioninget_connto resolve variable reuse typing errors.query_params(enforcing a literaldictto matchpyexasol's**query_paramsunpacking) andsqlstatements (rejecting lists inget_records/get_first). This respects theDbApiHookbase class interface while failing fast on invalid inputs.pyproject.tomltopyexasol>=2.0.0,<3, establishing a proper major-version ceiling.TypeError.README.rst,docs/index.rst, anddocs/changelog.rstto reflect the breaking changes and new dependencies.Testing
mypystrictness verified locally (0 errors inexasol.py).pyexasol 2.2.2to verify end-to-end type execution onconn.execute().