Support image digest in worker pod template image#69776
Open
PreethamSanji wants to merge 1 commit into
Open
Conversation
The pod_template_image helper only rendered repository:tag, ignoring digests, while airflow_image supports repository@digest with digest taking precedence over tag. Add images.pod_template.digest (falling back to defaultAirflowDigest) so worker pods can pin images by digest. Closes: apache#58625
e753bfb to
8eb573c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #58625
The
airflow_imagehelper supportsrepository@digest(digest takes precedence over tag), butpod_template_imageonly renderedrepository:tag. As a result, worker pods created from the pod template ignored digests and could run stale images when a mutable tag likelatestwas reused.This PR makes
pod_template_imagemirrorairflow_image: it introducesimages.pod_template.digest(added tovalues.yamlandvalues.schema.json— the schema hasadditionalProperties: falsefor this block), falling back todefaultAirflowDigest, consistent with the existing repository/tag fallback chains.Before (
helm template chart --set executor=KubernetesExecutor --set defaultAirflowRepository=my-repo --set defaultAirflowDigest=sha256:abc123):helm template chart
--set executor=KubernetesExecutor
--set defaultAirflowRepository=my-repo
--set defaultAirflowDigest=sha256:abc123 2>/dev/null
| grep "image: my-repo" | sort -u
image: my-repo:3.3.0
image: my-repo@sha256:abc123
After (same values):
helm template chart
--set executor=KubernetesExecutor
--set defaultAirflowRepository=my-repo
--set defaultAirflowDigest=sha256:abc123 2>/dev/null
| grep "image: my-repo" | sort -u
image: my-repo@sha256:abc123
Runtime caveat, documented in the new value's description: the chart defaults
config.kubernetes_executor.worker_container_repository/worker_container_tagtoimages.airflow.repository:tag, and when both are set the KubernetesExecutor overrides the pod template's base container image with thatrepo:tagstring (kube_config.pybuildskube_image;PodGenerator.construct_podreconciles it over the base pod). Sincerepo:tagcannot express a digest, the digest only takes effect when those two config options are unset — the same pre-existing limitation already documented forimages.pod_template.repository/tag. Making those config defaults digest-aware (defaulting them to empty when a digest is configured, so the template image wins) would fix the reporter's scenario with zero config changes, but it changes default behavior — happy to do that here or as a follow-up if preferred.Tests: parametrized rendering tests in
test_pod_template_file.pycovering tag-only, digest-only, digest precedence over tag, and thedefaultAirflowDigestfallback.flower_imagehas the same gap; I'd address it separately if wanted.Was generative AI tooling used to co-author this PR?
Claude Fable 5
Generated-by: [Claude Fable 5] following the guidelines
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.