Fence KubernetesExecutor launches with external executor IDs#69782
Open
wolvery wants to merge 1 commit into
Open
Fence KubernetesExecutor launches with external executor IDs#69782wolvery wants to merge 1 commit into
wolvery wants to merge 1 commit into
Conversation
Contributor
Author
|
Hey! I've tested it locally and it seems to have no other race condition happening |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes #69760.
This adds DB-backed launch-token fencing for KubernetesExecutor task launches:
external_executor_idtokensExecuteTaskworkloads and worker/runrequests/execution/task-instances/{id}/runrequests when the DB token no longer matchesThis prevents stale Kubernetes workloads from validly transitioning an obsolete task instance launch to RUNNING after a newer queued launch has replaced it.
Behavior notes
/runlaunch-token fence only applies when the worker actually presents a token. Older Task SDK workers (before this field existed) omit it entirely, and are not rejected mid-upgrade — they fall back to state-based validation. This keeps zero-downtime upgrades working for both KubernetesExecutor and CeleryExecutor, which share this pre-assigning/runpath.Tests
python3 -m compileall ...on modified source and test filesuv run ruff check ...uv run ruff format --check ...git diff --checkairflow-core/.../execution_api/versions/head/test_task_instances.py -k ti_run— 25 passed, 1 skipped (postgres-only)providers/cncf/kubernetes/.../executors/test_kubernetes_executor.py -k "sync or run_next or stale or external_executor"— all passedGen-AI disclosure
Generated-by: GPT following the guidelines: https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions