[v3-3-test] Fix generate-providers-metadata hang by using spawn pools (#69763)#69784
Draft
github-actions[bot] wants to merge 1 commit into
Draft
[v3-3-test] Fix generate-providers-metadata hang by using spawn pools (#69763)#69784github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
…#69763) The multiprocessing pools in the providers-metadata generation flow used the platform-default start method (fork on Linux). Before the pools are created the parent process has already used GitPython — which opens persistent `git cat-file --batch` subprocesses and is not fork-safe — and holds open network sockets from the version and constraints downloads. Forking that state into the workers left them with broken inherited file descriptors, so the pool deadlocked and the command hung forever, most reliably when --refresh-constraints-and-airflow-releases forces the parent through git and the network before forking. Switching these pools to the spawn start method gives each worker a clean interpreter with no inherited git subprocesses or sockets. (cherry picked from commit 5833692) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The multiprocessing pools in the providers-metadata generation flow used the
platform-default start method (fork on Linux). Before the pools are created the
parent process has already used GitPython — which opens persistent
git cat-file --batchsubprocesses and is not fork-safe — and holds opennetwork sockets from the version and constraints downloads. Forking that state
into the workers left them with broken inherited file descriptors, so the pool
deadlocked and the command hung forever, most reliably when
--refresh-constraints-and-airflow-releases forces the parent through git and the
network before forking.
Switching these pools to the spawn start method gives each worker a clean
interpreter with no inherited git subprocesses or sockets.
(cherry picked from commit 5833692)
Co-authored-by: Jarek Potiuk jarek@potiuk.com