Skip to content

Fix teststr segfault when built with -ftrivial-auto-var-init #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dimakuv wants to merge 1 commit into from
+9 −1
Closed

Fix teststr segfault when built with -ftrivial-auto-var-init #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,9 @@ jobs:
notest-cflags: -Werror
config: --enable-maintainer-mode --with-berkeley-db --with-dbm=db5
config-output: APU_HAVE_DB
- name: Auto-var-init
os: ubuntu-latest # requires gcc 12 or higher
notest-cflags: -ftrivial-auto-var-init=zero
fail-fast: false

runs-on: ${{ matrix.os }}
Expand Down
7 changes: 6 additions & 1 deletion test/teststr.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,15 @@ static void test_strtok(abts_case *tc, void *data)
" asdf jkl; 77889909 \r\n\1\2\3Z",
" \r\n\3\2\1"
},
#if 0
/* don't do this... apr_strtok() is not supposed to be called with
* str == NULL in the first invocation, otherwise it segfaults.
*/
{
NULL, /* but who cares if apr_strtok() segfaults? */
NULL,
" \t"
},
#endif
#if 0 /* don't do this... you deserve to segfault */
{
"a b c ",
Expand Down