perf(parquet/pqarrow): cap RecordReader batch size to actual row count#817
Open
paveon wants to merge 1 commit into
Open
perf(parquet/pqarrow): cap RecordReader batch size to actual row count#817paveon wants to merge 1 commit into
paveon wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
GetRecordReaderpassesBatchSizedirectly to the internalrecordReaderwithout capping it to the actual number of rows. When
BatchSizeis configuredto a large value (e.g. 131072) but the file or requested row groups contain
few rows (e.g. 10),
leafReader.LoadBatchcallsReserve(131072)whichpre-allocates definition/repetition level buffers and value buffers sized for
the full batch. For a 200-column int64 table with 10 rows this wastes ~250 MB
of allocations.
What changes are included in this PR?
Cap
batchSizetoNextPowerOf2(nrows)when aBatchSizeis explicitlyconfigured. The power-of-2 rounding keeps allocations aligned with the
downstream
updateCapacitylogic that already rounds to powers of two,avoiding a redundant reallocation on the first read.
Are these changes tested?
Existing tests pass. The change is on the allocation-sizing path only —
read correctness is unaffected since
LoadBatchalready stops readingwhen rows are exhausted.
Are there any user-facing changes?
No