GH-1098: [Java][Vector] Fix always-true precondition check in LargeListVector.setValueCount#1097
Closed
LuciferYang wants to merge 1 commit intoapache:mainfrom
Closed
Conversation
The precondition in LargeListVector.setValueCount() used `||` (logical OR) instead of `&&` (logical AND), making the check always evaluate to true. This meant childValueCount values exceeding Integer.MAX_VALUE or negative values would silently pass the check, leading to data truncation when cast to int on the next line. Changed `childValueCount <= Integer.MAX_VALUE || childValueCount >= Integer.MIN_VALUE` to `childValueCount <= Integer.MAX_VALUE && childValueCount >= 0`, consistent with the correct implementation in LargeListViewVector (line 888). Added two regression tests to verify the precondition rejects both negative and overflow childValueCount values.
LuciferYang
requested review from
jbonofre,
laurentgo,
lidavidm and
wgtmac
as code owners
LuciferYang
changed the title
|
Thank you for opening a pull request! Please label the PR with one or more of:
Also, add the 'breaking-change' label if appropriate. See CONTRIBUTING.md for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
Fix the precondition check in
LargeListVector.setValueCount()where||made the condition always true (childValueCount <= Integer.MAX_VALUE || childValueCount >= Integer.MIN_VALUEis a tautology for anylongvalue), allowing silent data corruption whenchildValueCountexceedsInteger.MAX_VALUEor is negative.Changes:
||with&&andInteger.MIN_VALUEwith0to correctly boundchildValueCountto[0, Integer.MAX_VALUE], consistent withLargeListViewVectorchildValueCountInteger.MAX_VALUEvaluesCloses #1098.