fix: Eliminate warnings for gcc16 and _FORTIFY_SOURCE=3 for snprintf#892
Open
paleolimbot wants to merge 3 commits into
Open
fix: Eliminate warnings for gcc16 and _FORTIFY_SOURCE=3 for snprintf#892paleolimbot wants to merge 3 commits into
paleolimbot wants to merge 3 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #892 +/- ##
==========================================
- Coverage 79.96% 78.59% -1.38%
==========================================
Files 105 106 +1
Lines 15461 16128 +667
Branches 1738 1858 +120
==========================================
+ Hits 12364 12675 +311
- Misses 1998 2286 +288
- Partials 1099 1167 +68 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ArrowSchemaToString()function usedsnprintf(NULL, 0, "...")to calculate final buffer sizes; however, this led to warnings (either because all NULLs are bad in this case or because the compiler couldn't prove thatnwas zero). This led to CRAN warnings for nanoarrow and all packages that vendored it because CRAN compiles on gcc16. Opus 4.5 seemed to suggest _FORTIFY_SOURCE=3 rejected all null inputs to snprintf, so this PR removes them.In the process I tidied up the printing a bit since it was hard to follow.