fix(aws): set retry_error_body on bulk_delete_request#733
Merged
Conversation
AWS S3 can return HTTP 200 with a SlowDown or InternalError XML body for DeleteObjects requests. The retry logic already handles this via body_contains_error() when retry_error_body is set, and other requests (copy_part, complete_multipart) already use this flag. bulk_delete_request was missing it, causing throttling errors to surface instead of being retried. Closes apache#277
tustvold
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #277
AWS S3 can return HTTP 200 with a SlowDown or InternalError XML body for DeleteObjects requests. The retry logic already handles this via body_contains_error() when retry_error_body is set, and other requests (copy_part, complete_multipart) already use this flag. bulk_delete_request was missing it, causing throttling errors to surface instead of being retried.