Skip to content

Minor: Restore warning comment on Int96 statistics read#7975

Merged
alamb merged 1 commit into
apache:mainfrom
alamb:alamb/fix_comment
Jul 23, 2025
Merged

Minor: Restore warning comment on Int96 statistics read#7975
alamb merged 1 commit into
apache:mainfrom
alamb:alamb/fix_comment

Conversation

@alamb

@alamb alamb commented Jul 22, 2025

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Rationale for this change

I merged #7687 without addressing one of @emkornfield 's suggestions: https://github.com/apache/arrow-rs/pull/7687/files#r2205393903

What changes are included in this PR?

Implement the suggestion (restore a comment_

Are these changes tested?

BY CI

Are there any user-facing changes?

No

@alamb alamb marked this pull request as ready for review July 22, 2025 22:07
@github-actions github-actions Bot added the parquet Changes to the parquet crate label Jul 22, 2025

@mbutrovich mbutrovich left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for not losing track of this, @alamb!

@emkornfield emkornfield left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@alamb

alamb commented Jul 23, 2025

Copy link
Copy Markdown
Contributor Author

Thank you @emkornfield and @mbutrovich -- since I do not think this PR is controversial (it puts back a comment that was previously present) I will just merge it now without waiting for additional reviews

@alamb alamb merged commit 16794ab into apache:main Jul 23, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

parquet Changes to the parquet crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants