GH-50551: [CI][Dev] Fix shellcheck errors in the ci/scripts/python_wheel_macos_build.sh by hiroyuki-sato · Pull Request #50552 · apache/arrow

hiroyuki-sato · 2026-07-20T12:14:00Z

Rationale for this change

This is the sub issue #44748.

SC2086: Double quote to prevent globbing and word splitting.
SC2223: This default assignment may cause DoS due to globbing. Quote it.
SC2006: Use $(...) notation instead of legacy backticked ....

shellcheck ci/scripts/python_wheel_macos_build.sh

In ci/scripts/python_wheel_macos_build.sh line 28:
rm -rf ${build_dir}/build
       ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
rm -rf "${build_dir}"/build


In ci/scripts/python_wheel_macos_build.sh line 29:
rm -rf ${build_dir}/install
       ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
rm -rf "${build_dir}"/install


In ci/scripts/python_wheel_macos_build.sh line 30:
rm -rf ${source_dir}/python/dist
       ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
rm -rf "${source_dir}"/python/dist


In ci/scripts/python_wheel_macos_build.sh line 31:
rm -rf ${source_dir}/python/build
       ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
rm -rf "${source_dir}"/python/build


In ci/scripts/python_wheel_macos_build.sh line 32:
rm -rf ${source_dir}/python/pyarrow/*.so
       ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
rm -rf "${source_dir}"/python/pyarrow/*.so


In ci/scripts/python_wheel_macos_build.sh line 33:
rm -rf ${source_dir}/python/pyarrow/*.so.*
       ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
rm -rf "${source_dir}"/python/pyarrow/*.so.*


In ci/scripts/python_wheel_macos_build.sh line 40:
if [ $arch = "arm64" ]; then
     ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
if [ "$arch" = "arm64" ]; then


In ci/scripts/python_wheel_macos_build.sh line 42:
  : ${ARROW_SIMD_LEVEL:="NEON"}
    ^-------------------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.


In ci/scripts/python_wheel_macos_build.sh line 43:
elif [ $arch = "x86_64" ]; then
       ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
elif [ "$arch" = "x86_64" ]; then


In ci/scripts/python_wheel_macos_build.sh line 45:
  : ${ARROW_SIMD_LEVEL:="SSE4_2"}
    ^---------------------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.


In ci/scripts/python_wheel_macos_build.sh line 55:
  -r ${source_dir}/python/requirements-wheel-build.txt
     ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
  -r "${source_dir}"/python/requirements-wheel-build.txt


In ci/scripts/python_wheel_macos_build.sh line 59:
: ${ARROW_ACERO:=ON}
  ^----------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.


In ci/scripts/python_wheel_macos_build.sh line 60:
: ${ARROW_AZURE:=ON}
  ^----------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.


In ci/scripts/python_wheel_macos_build.sh line 61:
: ${ARROW_DATASET:=ON}
  ^------------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.


In ci/scripts/python_wheel_macos_build.sh line 62:
: ${ARROW_FLIGHT:=ON}
  ^-----------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.


In ci/scripts/python_wheel_macos_build.sh line 63:
: ${ARROW_GANDIVA:=OFF}
  ^-------------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.


In ci/scripts/python_wheel_macos_build.sh line 64:
: ${ARROW_GCS:=ON}
  ^--------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.


In ci/scripts/python_wheel_macos_build.sh line 65:
: ${ARROW_HDFS:=ON}
  ^---------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.


In ci/scripts/python_wheel_macos_build.sh line 66:
: ${ARROW_JEMALLOC:=ON}
  ^-------------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.


In ci/scripts/python_wheel_macos_build.sh line 67:
: ${ARROW_MIMALLOC:=ON}
  ^-------------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.


In ci/scripts/python_wheel_macos_build.sh line 68:
: ${ARROW_ORC:=ON}
  ^--------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.


In ci/scripts/python_wheel_macos_build.sh line 69:
: ${ARROW_PARQUET:=ON}
  ^------------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.


In ci/scripts/python_wheel_macos_build.sh line 70:
: ${PARQUET_REQUIRE_ENCRYPTION:=ON}
  ^-- SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.


In ci/scripts/python_wheel_macos_build.sh line 71:
: ${ARROW_SUBSTRAIT:=ON}
  ^--------------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.


In ci/scripts/python_wheel_macos_build.sh line 72:
: ${ARROW_S3:=ON}
  ^-------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.


In ci/scripts/python_wheel_macos_build.sh line 73:
: ${ARROW_TENSORFLOW:=ON}
  ^---------------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.


In ci/scripts/python_wheel_macos_build.sh line 74:
: ${ARROW_WITH_BROTLI:=ON}
  ^----------------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.


In ci/scripts/python_wheel_macos_build.sh line 75:
: ${ARROW_WITH_BZ2:=ON}
  ^-------------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.


In ci/scripts/python_wheel_macos_build.sh line 76:
: ${ARROW_WITH_LZ4:=ON}
  ^-------------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.


In ci/scripts/python_wheel_macos_build.sh line 77:
: ${ARROW_WITH_OPENTELEMETRY:=ON}
  ^-----------------------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.


In ci/scripts/python_wheel_macos_build.sh line 78:
: ${ARROW_WITH_SNAPPY:=ON}
  ^----------------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.


In ci/scripts/python_wheel_macos_build.sh line 79:
: ${ARROW_WITH_ZLIB:=ON}
  ^--------------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.


In ci/scripts/python_wheel_macos_build.sh line 80:
: ${ARROW_WITH_ZSTD:=ON}
  ^--------------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.


In ci/scripts/python_wheel_macos_build.sh line 81:
: ${CMAKE_BUILD_TYPE:=release}
  ^--------------------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.


In ci/scripts/python_wheel_macos_build.sh line 82:
: ${CMAKE_GENERATOR:=Ninja}
  ^-----------------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.


In ci/scripts/python_wheel_macos_build.sh line 83:
: ${CMAKE_UNITY_BUILD:=ON}
  ^----------------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.


In ci/scripts/python_wheel_macos_build.sh line 84:
: ${VCPKG_ROOT:=/opt/vcpkg}
  ^-----------------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.


In ci/scripts/python_wheel_macos_build.sh line 85:
: ${VCPKG_FEATURE_FLAGS:=-manifests}
  ^-- SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.


In ci/scripts/python_wheel_macos_build.sh line 86:
: ${VCPKG_TARGET_TRIPLET:=${VCPKG_DEFAULT_TRIPLET:-x64-osx-static-${CMAKE_BUILD_TYPE}}}
  ^-- SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.


In ci/scripts/python_wheel_macos_build.sh line 93:
echo "$_pbc: `$_pbc --version`"
             ^---------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.

Did you mean:
echo "$_pbc: $($_pbc --version)"


In ci/scripts/python_wheel_macos_build.sh line 95:
mkdir -p ${build_dir}/build
         ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
mkdir -p "${build_dir}"/build


In ci/scripts/python_wheel_macos_build.sh line 96:
pushd ${build_dir}/build
      ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
pushd "${build_dir}"/build


In ci/scripts/python_wheel_macos_build.sh line 99:
    -DARROW_ACERO=${ARROW_ACERO} \
                  ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    -DARROW_ACERO="${ARROW_ACERO}" \


In ci/scripts/python_wheel_macos_build.sh line 100:
    -DARROW_AZURE=${ARROW_AZURE} \
                  ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    -DARROW_AZURE="${ARROW_AZURE}" \


In ci/scripts/python_wheel_macos_build.sh line 106:
    -DARROW_DATASET=${ARROW_DATASET} \
                    ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    -DARROW_DATASET="${ARROW_DATASET}" \


In ci/scripts/python_wheel_macos_build.sh line 110:
    -DARROW_FLIGHT=${ARROW_FLIGHT} \
                   ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    -DARROW_FLIGHT="${ARROW_FLIGHT}" \


In ci/scripts/python_wheel_macos_build.sh line 111:
    -DARROW_GANDIVA=${ARROW_GANDIVA} \
                    ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    -DARROW_GANDIVA="${ARROW_GANDIVA}" \


In ci/scripts/python_wheel_macos_build.sh line 112:
    -DARROW_GCS=${ARROW_GCS} \
                ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    -DARROW_GCS="${ARROW_GCS}" \


In ci/scripts/python_wheel_macos_build.sh line 113:
    -DARROW_HDFS=${ARROW_HDFS} \
                 ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    -DARROW_HDFS="${ARROW_HDFS}" \


In ci/scripts/python_wheel_macos_build.sh line 114:
    -DARROW_JEMALLOC=${ARROW_JEMALLOC} \
                     ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    -DARROW_JEMALLOC="${ARROW_JEMALLOC}" \


In ci/scripts/python_wheel_macos_build.sh line 116:
    -DARROW_MIMALLOC=${ARROW_MIMALLOC} \
                     ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    -DARROW_MIMALLOC="${ARROW_MIMALLOC}" \


In ci/scripts/python_wheel_macos_build.sh line 117:
    -DARROW_ORC=${ARROW_ORC} \
                ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    -DARROW_ORC="${ARROW_ORC}" \


In ci/scripts/python_wheel_macos_build.sh line 119:
    -DARROW_PARQUET=${ARROW_PARQUET} \
                    ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    -DARROW_PARQUET="${ARROW_PARQUET}" \


In ci/scripts/python_wheel_macos_build.sh line 121:
    -DARROW_S3=${ARROW_S3} \
               ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    -DARROW_S3="${ARROW_S3}" \


In ci/scripts/python_wheel_macos_build.sh line 122:
    -DARROW_SIMD_LEVEL=${ARROW_SIMD_LEVEL} \
                       ^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    -DARROW_SIMD_LEVEL="${ARROW_SIMD_LEVEL}" \


In ci/scripts/python_wheel_macos_build.sh line 123:
    -DARROW_SUBSTRAIT=${ARROW_SUBSTRAIT} \
                      ^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    -DARROW_SUBSTRAIT="${ARROW_SUBSTRAIT}" \


In ci/scripts/python_wheel_macos_build.sh line 124:
    -DARROW_TENSORFLOW=${ARROW_TENSORFLOW} \
                       ^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    -DARROW_TENSORFLOW="${ARROW_TENSORFLOW}" \


In ci/scripts/python_wheel_macos_build.sh line 127:
    -DARROW_WITH_BROTLI=${ARROW_WITH_BROTLI} \
                        ^------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    -DARROW_WITH_BROTLI="${ARROW_WITH_BROTLI}" \


In ci/scripts/python_wheel_macos_build.sh line 128:
    -DARROW_WITH_BZ2=${ARROW_WITH_BZ2} \
                     ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    -DARROW_WITH_BZ2="${ARROW_WITH_BZ2}" \


In ci/scripts/python_wheel_macos_build.sh line 129:
    -DARROW_WITH_LZ4=${ARROW_WITH_LZ4} \
                     ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    -DARROW_WITH_LZ4="${ARROW_WITH_LZ4}" \


In ci/scripts/python_wheel_macos_build.sh line 130:
    -DARROW_WITH_OPENTELEMETRY=${ARROW_WITH_OPENTELEMETRY} \
                               ^-------------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    -DARROW_WITH_OPENTELEMETRY="${ARROW_WITH_OPENTELEMETRY}" \


In ci/scripts/python_wheel_macos_build.sh line 131:
    -DARROW_WITH_SNAPPY=${ARROW_WITH_SNAPPY} \
                        ^------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    -DARROW_WITH_SNAPPY="${ARROW_WITH_SNAPPY}" \


In ci/scripts/python_wheel_macos_build.sh line 132:
    -DARROW_WITH_ZLIB=${ARROW_WITH_ZLIB} \
                      ^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    -DARROW_WITH_ZLIB="${ARROW_WITH_ZLIB}" \


In ci/scripts/python_wheel_macos_build.sh line 133:
    -DARROW_WITH_ZSTD=${ARROW_WITH_ZSTD} \
                      ^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    -DARROW_WITH_ZSTD="${ARROW_WITH_ZSTD}" \


In ci/scripts/python_wheel_macos_build.sh line 135:
    -DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE} \
                       ^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    -DCMAKE_BUILD_TYPE="${CMAKE_BUILD_TYPE}" \


In ci/scripts/python_wheel_macos_build.sh line 137:
    -DCMAKE_INSTALL_PREFIX=${build_dir}/install \
                           ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    -DCMAKE_INSTALL_PREFIX="${build_dir}"/install \


In ci/scripts/python_wheel_macos_build.sh line 139:
    -DCMAKE_UNITY_BUILD=${CMAKE_UNITY_BUILD} \
                        ^------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    -DCMAKE_UNITY_BUILD="${CMAKE_UNITY_BUILD}" \


In ci/scripts/python_wheel_macos_build.sh line 140:
    -DPARQUET_REQUIRE_ENCRYPTION=${PARQUET_REQUIRE_ENCRYPTION} \
                                 ^---------------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    -DPARQUET_REQUIRE_ENCRYPTION="${PARQUET_REQUIRE_ENCRYPTION}" \


In ci/scripts/python_wheel_macos_build.sh line 142:
    -DVCPKG_TARGET_TRIPLET=${VCPKG_TARGET_TRIPLET} \
                           ^---------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    -DVCPKG_TARGET_TRIPLET="${VCPKG_TARGET_TRIPLET}" \


In ci/scripts/python_wheel_macos_build.sh line 144:
    -G ${CMAKE_GENERATOR} \
       ^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    -G "${CMAKE_GENERATOR}" \


In ci/scripts/python_wheel_macos_build.sh line 145:
    ${source_dir}/cpp
    ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    "${source_dir}"/cpp


In ci/scripts/python_wheel_macos_build.sh line 171:
pushd ${source_dir}/python
      ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
pushd "${source_dir}"/python


In ci/scripts/python_wheel_macos_build.sh line 174:
  -C cmake.build-type=${CMAKE_BUILD_TYPE:-Debug} \
                      ^------------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
  -C cmake.build-type="${CMAKE_BUILD_TYPE:-Debug}" \


In ci/scripts/python_wheel_macos_build.sh line 180:
deps=$(delocate-listdeps ${source_dir}/python/dist/*.whl)
                         ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
deps=$(delocate-listdeps "${source_dir}"/python/dist/*.whl)


In ci/scripts/python_wheel_macos_build.sh line 182:
if echo $deps | grep -v "^pyarrow/lib\(arrow\|gandiva\|parquet\)"; then
        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
if echo "$deps" | grep -v "^pyarrow/lib\(arrow\|gandiva\|parquet\)"; then


In ci/scripts/python_wheel_macos_build.sh line 188:
mkdir -p ${source_dir}/python/repaired_wheels
         ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
mkdir -p "${source_dir}"/python/repaired_wheels


In ci/scripts/python_wheel_macos_build.sh line 189:
mv ${source_dir}/python/dist/*.whl ${source_dir}/python/repaired_wheels/
   ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                   ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
mv "${source_dir}"/python/dist/*.whl "${source_dir}"/python/repaired_wheels/

For more information:
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
  https://www.shellcheck.net/wiki/SC2223 -- This default assignment may cause...
  https://www.shellcheck.net/wiki/SC2006 -- Use $(...) notation instead of le...

What changes are included in this PR?

SC2086: Quote variable expansions
SC2223: Simplify default assignment
SC2006: Replace backticks with $(...)

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

GitHub Issue: [CI][Dev] Fix shellcheck errors in the ci/scripts/python_wheel_macos_build.sh #50551

github-actions · 2026-07-20T12:14:50Z

⚠️ GitHub issue #50551 has been automatically assigned in GitHub to PR creator.

hiroyuki-sato · 2026-07-20T12:19:31Z

I’m waiting for #50535 to be merged

hiroyuki-sato · 2026-07-20T12:24:05Z

+: "${CMAKE_GENERATOR:=Ninja}"
+: "${CMAKE_UNITY_BUILD:=ON}"
+: "${VCPKG_ROOT:=/opt/vcpkg}"
+: "${VCPKG_FEATURE_FLAGS:=-manifests}"


It doesn’t seem to be used anywhere. Is it used by a subshell or a child process? If not, can we remove it?

Or, Can we split into array?

It's used by vcpkg: https://learn.microsoft.com/en-us/vcpkg/users/config-environment#vcpkg_feature_flags

Thank you for your comment.

Finally, since VCPKG_FEATURE_FLAGS is consumed as an environment variable, I think we can leave it as is. Is that correct?

Yes. We may need export VCPKG_FEATURE_FLAGS but it's not a problem of this.

…hon_wheel_macos_build.sh

hiroyuki-sato · 2026-07-20T23:58:28Z

@github-actions crossbow submit wheel-macos*

github-actions · 2026-07-21T00:00:57Z

Revision: 29bbb5f

Submitted crossbow builds: ursacomputing/crossbow @ actions-6775337f5b

Task	Status
wheel-macos-monterey-cp311-cp311-amd64
wheel-macos-monterey-cp311-cp311-arm64
wheel-macos-monterey-cp312-cp312-amd64
wheel-macos-monterey-cp312-cp312-arm64
wheel-macos-monterey-cp313-cp313-amd64
wheel-macos-monterey-cp313-cp313-arm64
wheel-macos-monterey-cp314-cp314-amd64
wheel-macos-monterey-cp314-cp314-arm64
wheel-macos-monterey-cp314-cp314t-amd64
wheel-macos-monterey-cp314-cp314t-arm64

Co-authored-by: Sutou Kouhei <kou@cozmixng.org>

kou

+1

kou · 2026-07-21T01:48:05Z

@github-actions crossbow submit wheel-macos*

github-actions · 2026-07-21T01:50:40Z

Revision: a6afea9

Submitted crossbow builds: ursacomputing/crossbow @ actions-e1dd72f053

Task	Status
wheel-macos-monterey-cp311-cp311-amd64
wheel-macos-monterey-cp311-cp311-arm64
wheel-macos-monterey-cp312-cp312-amd64
wheel-macos-monterey-cp312-cp312-arm64
wheel-macos-monterey-cp313-cp313-amd64
wheel-macos-monterey-cp313-cp313-arm64
wheel-macos-monterey-cp314-cp314-amd64
wheel-macos-monterey-cp314-cp314-arm64
wheel-macos-monterey-cp314-cp314t-amd64
wheel-macos-monterey-cp314-cp314t-arm64

github-actions Bot added the awaiting review Awaiting review label Jul 20, 2026

hiroyuki-sato commented Jul 20, 2026

View reviewed changes

github-actions Bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Jul 20, 2026

apacheGH-50551: [CI][Dev] Fix shellcheck errors in the ci/scripts/pyt…

29bbb5f

…hon_wheel_macos_build.sh

hiroyuki-sato force-pushed the topic/shellcheck-python_wheel_macos_build branch from a663e02 to 29bbb5f Compare July 20, 2026 23:48

hiroyuki-sato marked this pull request as ready for review July 20, 2026 23:49

hiroyuki-sato requested review from assignUser, jonkeane, kou and raulcd as code owners July 20, 2026 23:49

kou reviewed Jul 21, 2026

View reviewed changes

Comment thread ci/scripts/python_wheel_macos_build.sh Outdated

github-actions Bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Jul 21, 2026

Apply suggestion from @kou

a6afea9

Co-authored-by: Sutou Kouhei <kou@cozmixng.org>

github-actions Bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Jul 21, 2026

kou approved these changes Jul 21, 2026

View reviewed changes

github-actions Bot added awaiting merge Awaiting merge awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Jul 21, 2026

kou merged commit c78314b into apache:main Jul 21, 2026
39 checks passed

kou removed awaiting changes Awaiting changes awaiting merge Awaiting merge labels Jul 21, 2026

kou mentioned this pull request Jul 21, 2026

[CI][Dev] Fix shellcheck errors in the ci/scripts/python_wheel_macos_build.sh #50551

Closed

hiroyuki-sato deleted the topic/shellcheck-python_wheel_macos_build branch July 21, 2026 09:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

GH-50551: [CI][Dev] Fix shellcheck errors in the ci/scripts/python_wheel_macos_build.sh#50552

GH-50551: [CI][Dev] Fix shellcheck errors in the ci/scripts/python_wheel_macos_build.sh#50552
kou merged 2 commits into
apache:mainfrom
hiroyuki-sato:topic/shellcheck-python_wheel_macos_build

hiroyuki-sato commented Jul 20, 2026 •

edited by github-actions Bot

Loading

Uh oh!

github-actions Bot commented Jul 20, 2026

Uh oh!

hiroyuki-sato commented Jul 20, 2026

Uh oh!

hiroyuki-sato Jul 20, 2026

Uh oh!

kou Jul 21, 2026

Uh oh!

hiroyuki-sato Jul 21, 2026

Uh oh!

kou Jul 21, 2026

Uh oh!

hiroyuki-sato commented Jul 20, 2026

Uh oh!

github-actions Bot commented Jul 21, 2026

Uh oh!

Uh oh!

kou left a comment

Uh oh!

kou commented Jul 21, 2026

Uh oh!

github-actions Bot commented Jul 21, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

hiroyuki-sato commented Jul 20, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Uh oh!

github-actions Bot commented Jul 20, 2026

Uh oh!

hiroyuki-sato commented Jul 20, 2026

Uh oh!

hiroyuki-sato Jul 20, 2026

Choose a reason for hiding this comment

Uh oh!

kou Jul 21, 2026

Choose a reason for hiding this comment

Uh oh!

hiroyuki-sato Jul 21, 2026

Choose a reason for hiding this comment

Uh oh!

kou Jul 21, 2026

Choose a reason for hiding this comment

Uh oh!

hiroyuki-sato commented Jul 20, 2026

Uh oh!

github-actions Bot commented Jul 21, 2026

Uh oh!

Uh oh!

kou left a comment

Choose a reason for hiding this comment

Uh oh!

kou commented Jul 21, 2026

Uh oh!

github-actions Bot commented Jul 21, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

hiroyuki-sato commented Jul 20, 2026 •

edited by github-actions Bot

Loading