Skip to content

fix: include <any> in sstream_workaround.h to fix C++17 build #3346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Felix-Gong wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −0
Open

fix: include <any> in sstream_workaround.h to fix C++17 build #3346

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions test/sstream_workaround.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,22 @@
// defining private as public makes it fail to compile sstream with gcc5.x like this:
// "error: ‘struct std::__cxx11::basic_stringbuf<_CharT, _Traits, _Alloc>::
// __xfer_bufptrs’ redeclared with different access"
//
// Similarly, std::any in C++17 uses private access specifiers internally that
// would break with -Dprivate=public. Include it here before the macro takes effect.

#ifdef private
# undef private
# include <sstream>
# if __cplusplus >= 201703L
# include <any>
# endif
# define private public

@chenBright chenBright Jun 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using -fno-access-control instead of # define private public?

#else
# include <sstream>
# if __cplusplus >= 201703L
# include <any>
# endif
#endif

#endif // BUTIL_TEST_SSTREAM_WORKAROUND
Loading