INFRA-27679 - Avoid squash to avoid new very large commit on each new#1573
Conversation
| sh 'git rm -q -r *' | ||
| sh "cp -R $WORKSPACE/camel-website/public/. ." | ||
| sh 'git add .' | ||
| sh "git checkout $STOP_SQUASH_AT -- ./.asf.yaml" // force revert to commit containing the valid .asf.yml |
There was a problem hiding this comment.
need to check the content of the .asf.yaml which will be provided then, maybe will need to change something how the .asf.yaml is genrated or to continue to checkout one from a specific revision.
I'm wondering if the problem is not that we wan a different .asf.yaml between camel-website repo and camel-website-pub
There was a problem hiding this comment.
@gansheer as you introduced the line for that, maybe you can provide a bit more context?
There was a problem hiding this comment.
I only modified that line but yes there is context: #1410 (comment). From what I remember we squash every commit to avoid the repo to grow too much (I would say in storage and history). But since we want to keep the .asf.yaml file from the camel-website-pub repo (and not the one from the camel-website repo) we retrieve the valid version from a defined commit we decided contained the right version.
I think with your change we will end with camel-website .asf.yml file inside camel-website-pub so it probably won't work well.
camel-website: https://github.com/apache/camel-website/blob/main/.asf.yaml
camel-website-pub: https://github.com/apache/camel-website-pub/blob/asf-site/.asf.yaml
There was a problem hiding this comment.
ok, so I changed the PR to keep the .asf.yaml from the camel-website-pub
|
🚀 Preview is available at https://pr-1573--camel.netlify.app |
|
@zregvart ^^^ in case you want to take a quick look |
website build the newly created very large commit created on each push might be the cause of the 404 as the CDN might have problems to handle it right away. Based on https://issues.apache.org/jira/browse/INFRA-27679?focusedCommentId=18062765&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-18062765 It means that the history will grow. So we might need to ensure that the checkout of this site is either done with a depth of 1 or if already available and just a pull is done maybe to squash one time manually from time to time. see https://issues.apache.org/jira/browse/INFRA-27679?focusedCommentId=18073130&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-18073130 Signed-off-by: Aurélien Pupier <apupier@ibm.com>
apupier
force-pushed
the
INFRA-27679-attemptToAvoid404ByAvoidingSquashCreatingANewVeryLargeCommits
branch
from
576a825 to
67d9e23
Compare
|
🚀 Preview is available at https://pr-1573--camel.netlify.app |
apupier
deleted the
INFRA-27679-attemptToAvoid404ByAvoidingSquashCreatingANewVeryLargeCommits
branch
4 participants
website build
the newly created very large commit created on each push might be the cause of the 404 as the CDN might have problems to handle it right away. Based on https://issues.apache.org/jira/browse/INFRA-27679?focusedCommentId=18062765&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-18062765
It means that the history will grow. So we might need to ensure that the checkout of this site is either done with a depth of 1 or if already available and just a pull is done maybe to squash one time manually from time to time.
see https://issues.apache.org/jira/browse/INFRA-27679?focusedCommentId=18073130&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-18073130