CASSSIDECAR-447: Scope all CDC dependencies exclusively to CdcModule#341
Open
yifan-c wants to merge 1 commit into
Open
CASSSIDECAR-447: Scope all CDC dependencies exclusively to CdcModule#341yifan-c wants to merge 1 commit into
yifan-c wants to merge 1 commit into
Conversation
yifan-c
commented
Apr 30, 2026
Contributor
Author
There was a problem hiding this comment.
The file is removed and the functionality (i.e. isCdcOnRepairEnabled) is merged into CdcSystemViewsDatabaseAccessor as they both access the settings vtable.
yifan-c
commented
Apr 30, 2026
| ServiceConfiguration serviceConfiguration) | ||
| { | ||
| return new DynamicSidecarInstancesProvider(instancesMetadata, serviceConfiguration); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
It was declared in the CdcModule, but should really be moved there as it is used by other components.
yifan-c
commented
May 1, 2026
yifan-c
force-pushed
the
CASSSIDECAR-447/cdc-module-refactoring
branch
from
bada091 to
892101a
Compare
jyothsnakonisa
approved these changes
May 4, 2026
Contributor
jyothsnakonisa
left a comment
jyothsnakonisa
left a comment
There was a problem hiding this comment.
Looks good overall, just minor comment.
yifan-c
force-pushed
the
CASSSIDECAR-447/cdc-module-refactoring
branch
from
0258475 to
9bdbcf7
Compare
Patch by Yifan Cai; Reviewed by TBD for CASSSIDECAR-447
yifan-c
force-pushed
the
CASSSIDECAR-447/cdc-module-refactoring
branch
from
a016bf5 to
f8982a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch by Yifan Cai; Reviewed by TBD for CASSSIDECAR-447