CASSSIDECAR-453 cdc events routing#344
Merged
Merged
Conversation
smiklosovic
force-pushed
the
CASSSIDECAR-453
branch
from
1c1a24b to
bf02b57
Compare
smiklosovic
commented
May 27, 2026
| instance.delegate().nodeSettings()).releaseVersion() | ||
| ).getVersion(); | ||
| this.kafkaPublisher = KafkaPublisher.create(version, | ||
| TopicSupplier.staticTopicSupplier(conf.kafkaTopic()), |
Contributor
Author
There was a problem hiding this comment.
conf.kafkaTopic() is annotated with @Nullable. I do not know what we should do when it returns null. This was already the case before this patch. I do not see anything which would validate if kafka topic is null or not. Might be deferred to another ticket though.
jyothsnakonisa
approved these changes
May 27, 2026
Contributor
jyothsnakonisa
left a comment
jyothsnakonisa
left a comment
There was a problem hiding this comment.
Thanks Stefan, looks good to me. Please fix the check style
smiklosovic
force-pushed
the
CASSSIDECAR-453
branch
from
bf02b57 to
7ed3752
Compare
…rmat configuration patch by Stefan Miklosovic; reviewed by Jyothsna Konisa for CASSSIDECAR-453
smiklosovic
force-pushed
the
CASSSIDECAR-453
branch
from
7ed3752 to
0f3df76
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.