CASSSIDECAR-454: Sidecar should wake up immediately on the instance r…#346
Open
mansikhara wants to merge 9 commits into
Open
CASSSIDECAR-454: Sidecar should wake up immediately on the instance r…#346mansikhara wants to merge 9 commits into
mansikhara wants to merge 9 commits into
Conversation
yifan-c
reviewed
May 13, 2026
Contributor
|
|
yifan-c
reviewed
May 16, 2026
sarankk
reviewed
May 19, 2026
Contributor
sarankk
left a comment
There was a problem hiding this comment.
Thanks Mansi, looks good. Left some comments.
added 7 commits
May 20, 2026 15:20
…eceiving a phase signal instead of waiting for the discovery loop
…eceiving a phase signal instead of waiting for the discovery loop
…eceiving a phase signal instead of waiting for the discovery loop
…eceiving a phase signal instead of waiting for the discovery loop
…eceiving a phase signal instead of waiting for the discovery loop
…eceiving a phase signal instead of waiting for the discovery loop
…eceiving a phase signal instead of waiting for the discovery loop
490771a to
651e5fc
Compare
added 2 commits
May 21, 2026 10:43
…eceiving a phase signal instead of waiting for the discovery loop
…eceiving a phase signal instead of waiting for the discovery loop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UpdateRestoreJobHandler now immediately notifies the restore system after writing a phase signal (STAGE_READY or IMPORT_READY) to the DB, eliminating the 5–10 minute idle wait for the next RestoreJobDiscoverer polling cycle.
RestoreJobManagerGroup.updateRestoreJob()to propagate the new status to in-memory trackers, allowingRestoreProcessorto unblock stagedranges on its next 1-second tick.
RestoreJobDiscoverer.processJobNow()which discovers slices from the DB and submits them toRestoreProcessorimmediately.Design decisions
executeBlocking) — does not block the event loop or delay the HTTP 200 response.notifyPhaseSignalMaybebecauseRestoreJobDatabaseAccessor.update()returns a sparse object missing fields like keyspace andconsistency level.
the immediate notification fails.
Test plan
UpdateRestoreJobHandlerTest— new tests verify IMPORT_READY triggersupdateRestoreJoband STAGE_READY triggersprocessJobNowRestoreJobDiscovererPhaseSignalIntTest— new integration tests verify ranges are created immediately on STAGE_READY without explicit discovery, andIMPORT_READY does not create duplicates
RestoreJobDiscovererNode*IntTesttests pass (regression)