Number of running and stopped VMs as preset variables for Network type Quota tariffs

[hsato03]

Description

This PR aims to add two new preset variables for Network type Quota tariffs: value.resourceCounting.runningVms and value.resourceCounting.stoppedVms.

They represent the number of user instances that have a NIC on the network being processed. The preset variable value.resourceCounting.runningVms refers to the number of running instances, and value.resourceCounting.stoppedVms refers to the number of stopped instances.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

I created 3 VMs on the same guest network (2 of them in running state and 1 in stopped state), then I created a Network Quota tariff with the following activation rule:

if (value.resourceCounting.runningVms == 2 && value.resourceCounting.stoppedVms == 1) {
300
} else {
0
}

I called the quotaUpdate API via CMK and verified that the value 300 was being returned when executing the activation rule.

How did you try to break this feature and the system with this change?

[hsato03]

@blueorangutan package

[blueorangutan]

@hsato03 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

❌ Patch coverage is 90.90909% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 18.02%. Comparing base (1bff543) to head (cfc82cb).
⚠️ Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
...tivationrule/presetvariables/ResourceCounting.java	81.25%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               main   #11689   +/-   ##
=========================================
  Coverage     18.02%   18.02%           
- Complexity    16460    16469    +9     
=========================================
  Files          5968     5969    +1     
  Lines        537213   537250   +37     
  Branches      65975    65977    +2     
=========================================
+ Hits          96825    96862   +37     
  Misses       429469   429469           
  Partials      10919    10919           

Flag	Coverage Δ
uitests	3.53% <ø> (ø)
unittests	19.19% <90.90%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15116

[bernardodemarco]

code lgtm, did not test it

[hsato03]

@blueorangutan package

[blueorangutan]

@hsato03 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17292