Show accounts/projects belonging to the selected domain in the VM import wizard#13156
Show accounts/projects belonging to the selected domain in the VM import wizard#13156Tonitzpp wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.20 #13156 +/- ##
============================================
- Coverage 16.27% 16.26% -0.01%
+ Complexity 13440 13434 -6
============================================
Files 5665 5665
Lines 500555 500576 +21
Branches 60789 60798 +9
============================================
- Hits 81445 81419 -26
- Misses 410004 410050 +46
- Partials 9106 9107 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
There was a problem hiding this comment.
Pull request overview
This PR updates the VM import wizard UI to allow selecting a domain and then automatically listing the accounts/projects available within that domain, removing the need to manually type an account name during import.
Changes:
- Replaces the inline domain/account/project inputs with the reusable
OwnershipSelectioncomponent for non-normal users. - Introduces an
ownerstate object and uses it to drive ownership parameters during import submission. - Attempts to scope related selections (e.g., networks) based on the chosen owner.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| :domainid="form.domainid" | ||
| :account="form.account" | ||
| :domainid="this.owner.domainid" | ||
| :accountid="this.owner.account" |
| accounts: { | ||
| list: 'listAccounts', | ||
| isLoad: true, | ||
| options: { | ||
| domainid: this.domainid | ||
| }, | ||
| field: 'accountid' |
| initForm () { | ||
| this.formRef = ref() | ||
| this.form = reactive({ | ||
| rootdiskid: 0, | ||
| migrateallowed: this.switches.migrateAllowed, | ||
| forced: this.switches.forced, | ||
| forcemstoimportvmfiles: this.switches.forceMsToImportVmFiles, | ||
| domainid: null, | ||
| account: null | ||
| accountid: null | ||
| }) |
|
@Tonitzpp could you check whether the things pointed out by copilot make sense? |
Description
When importing a VM into ACS management, if a domain is selected, ACS does not display the accounts for the selected domain and forces the operator to manually enter the account name.
This PR modifies the UI so that, when a domain is selected, the accounts/projects for that domain are automatically listed.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Screenshots (if appropriate):
How Has This Been Tested?
To perform the tests, a new domain called
Domainwas created, and a VM and a new network were created within it. After creating the VM, I unmanaged it and then imported it back into the same domain and account using the graphical interface, checking that the accounts belonging to the domain were automatically listed in the import menu. The same test was performed for a project.