fix(ui): validate OOBM is enabled before allowing HA on KVM hosts (#13605) by Chinmay048 · Pull Request #13647 · apache/cloudstack

Chinmay048 · 2026-07-19T18:20:08Z

Description

This PR updates the Vue UI infrastructure configuration (hosts.js) to validate that Out-of-Band Management (OOBM) is active and enabled before allowing administrators to configure or enable High Availability (HA) on KVM hosts. If OOBM is not enabled on a KVM host, the HA action buttons are cleanly hidden to prevent invalid configurations.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Bug Severity

How Has This Been Tested?

Verified in the Vue UI that for KVM hosts where record.outofbandmanagement.enabled is false or undefined, the "Configure HA" and "Enable HA" action buttons are properly hidden.
Verified that KVM hosts with active OOBM configurations (and Simulator hosts) continue to display the HA action buttons normally.

…he#13639)

…ache#13605)

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

kiranchavala · 2026-07-20T04:31:43Z

@blueorangutan ui

blueorangutan · 2026-07-20T04:33:04Z

@kiranchavala a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

codecov · 2026-07-20T04:40:24Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 19.64%. Comparing base (75748a5) to head (068213b).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #13647      +/-   ##
============================================
- Coverage     19.65%   19.64%   -0.01%     
+ Complexity    19792    19789       -3     
============================================
  Files          6368     6368              
  Lines        575107   575119      +12     
  Branches      70370    70373       +3     
============================================
- Hits         113016   112987      -29     
- Misses       449808   449849      +41     
  Partials      12283    12283

Flag	Coverage Δ
uitests	`3.41% <ø> (-0.01%)`	⬇️
unittests	`20.92% <ø> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

blueorangutan · 2026-07-20T04:53:34Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/13647 (QA-JID-964)

kiranchavala · 2026-07-20T12:25:05Z

@blueorangutan package

blueorangutan · 2026-07-20T12:26:05Z

@kiranchavala a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-07-20T13:26:17Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18620

kiranchavala · 2026-07-21T04:43:51Z

cc @weizhouapache @winterhazel

Consider this UI improvement for the 4.23 release

kiranchavala

Looks good

Message when user tries to Enable OOBM

Message when user tries to Enable HA

Wondering if we should Disable HA when OOBM is also disabled

cc @sureshanaparti

kiranchavala · 2026-07-21T09:24:38Z

@Chinmay048 when admin clicks on Disable OOBM ,cloudstack should thrown a pop-up saying that to Disable HA First

Only if the HA is disabled we should allow to disable the OOBM

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Chinmay048 · 2026-07-21T10:02:20Z

Thanks for the review and feedback @kiranchavala! That makes complete sense to guard the teardown flow as well.

I am working on updating the Disable OOBM action right now so that if a host currently has High Availability (HA) enabled, the UI will intercept the action and display a warning pop-up instructing the admin to disable HA first before allowing OOBM to be turned off. Will push the commit to this PR shortly!

…ve HA hosts (apache#13605)

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

kiranchavala · 2026-07-21T13:19:01Z

@blueorangutan package

blueorangutan · 2026-07-21T13:20:05Z

@kiranchavala a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

      action.resource = this.resource
+      const record = this.resource || this.item
+      if (action?.api === 'disableOutOfBandManagementForHost' && (record?.hostha?.haenable === true || record?.hastate === 'Enabled')) {


+      show: (record) => {
+        if (record.hypervisor === 'KVM') {
+          return Boolean(record?.outofbandmanagement?.enabled)
+        }
+        return record.hypervisor === 'Simulator'
+      },


+        if (record.hypervisor === 'KVM') {
+          return Boolean(record?.outofbandmanagement?.enabled)
+        }


      </template>
-
-      <template v-if="column.key === 'clustername'">
+<template v-if="column.key === 'clustername'">


            <router-link
-              v-if="$route.path.startsWith('/quotasummary') && $router.resolve(`${$route.path}/${record.accountid}`).matched[0].redirect !== '/exception/404'"
+              v-if="$route.path.startsWith('/quotasummary')"
              :to="{ path: `${$route.path}/${record.accountid}` }">{{ text }}</router-link>


        <template v-if="text">
          <template v-if="!text.startsWith('PrjAcct-')">
            <router-link
-              v-if="$route.path.startsWith('/quotasummary') && $router.resolve(`${$route.path}/${record.accountid}`).matched[0].redirect !== '/exception/404'"
+              v-if="$route.path.startsWith('/quotasummary')"
              :to="{ path: `${$route.path}/${record.accountid}` }">{{ text }}</router-link>
-            <span v-else>{{ text }}</span>
-          </template>
-          <template v-else>
+            <router-link v-else-if="record.accountid" :to="{ path: '/account/' + record.accountid }">{{ text }}</router-link>
            <router-link
-              v-if="$route.path.startsWith('/quotasummary') && $router.resolve(`${$route.path}/${record.accountid}`).matched[0].redirect !== '/exception/404'"
-              :to="{ path: `${$route.path}/${record.accountid}` }">{{ (record.projectname || record.account).concat(' (').concat($t('label.project')).concat(')') }}</router-link>
+              v-else-if="$store.getters.userInfo.roletype !== 'User'"
+              :to="{ path: '/account', query: { name: record.account, domainid: record.domainid, dataView: true } }">
+              {{ text }}
+            </router-link>
            <span v-else>{{ text }}</span>


blueorangutan · 2026-07-21T14:06:43Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18634

winterhazel · 2026-07-21T16:47:35Z

cc @weizhouapache @winterhazel

Consider this UI improvement for the 4.23 release

@kiranchavala I intend to cut a RC2 tomorrow around 2026-07-22 16:00 GMT. I will include this patch if it is ready by then.

This issue is not major to block 4.23 RC2, as it does not prevent any operations via the UI or result in any bugs. The patch needs some adjustments as well (I'll send some reviews later).

Damans227 · 2026-07-21T18:44:00Z

      </template>
-
-      <template v-if="column.key === 'clustername'">
+<template v-if="column.key === 'clustername'">


Nit: this line lost its indentation, looks like an accidental de-indent (surrounding <template> blocks are indented 6 spaces).

Damans227 · 2026-07-21T18:44:00Z

+      if (action?.api === 'disableOutOfBandManagementForHost' && (record?.hostha?.haenable === true || record?.hastate === 'Enabled')) {
+        this.$notification.error({
+          message: this.$t('label.error'),
+          description: 'Please disable High Availability (HA) on this host before disabling Out-of-Band Management (OOBM).',


Nit: hardcoded English string here instead of $t(), rest of the UI runs user-facing messages through i18n.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (3)

ui/src/components/view/ActionButton.vue:181

execAction references this.item, but ActionButton doesn't define an item prop/data/computed. This means record will never fall back to the clicked row item and will also trigger Vue warnings about accessing undefined instance properties. Prefer deriving record from resource and assigning action.resource from the same value to keep downstream action handling consistent.

    execAction (action) {
      action.resource = this.resource
      const record = this.resource || this.item
      if (action?.api === 'disableOutOfBandManagementForHost' && (record?.hostha?.haenable === true || record?.hastate === 'Enabled')) {

ui/src/components/view/ListView.vue:658

The <template v-if="column.key === 'clustername'"> line lost its indentation, which makes this block inconsistent with the surrounding template and may violate Vue/ESLint formatting rules.

<template v-if="column.key === 'clustername'">

ui/src/components/view/ListView.vue:696

The updated account-column rendering has two functional regressions: (1) for PrjAcct-* values outside /quotasummary, nothing is rendered (no v-else fallback), leaving the cell blank; (2) the /quotasummary link is created even when record.accountid is missing and without the previous 404-route guard, which can produce links to invalid routes.

        <template v-if="text">
          <template v-if="!text.startsWith('PrjAcct-')">
            <router-link
              v-if="$route.path.startsWith('/quotasummary')"
              :to="{ path: `${$route.path}/${record.accountid}` }">{{ text }}</router-link>

Chinmay048 added 4 commits July 17, 2026 10:41

fix(ui): restore Account column hyperlink routing in list views (apac…

5f29065

…he#13639)

fix(ui): use v-else-if for Account column routing per maintainer review

4de326a

refactor(ui): revert whitespace noise and restore v-if directive

9e98d68

fix(ui): validate OOBM is enabled before allowing HA on KVM hosts (ap…

ba1f5a5

…ache#13605)

Copilot AI review requested due to automatic review settings July 19, 2026 18:20

boring-cyborg Bot added the component:UI label Jul 19, 2026

Copilot AI reviewed Jul 19, 2026

kiranchavala reviewed Jul 21, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings July 21, 2026 10:01

Copilot AI reviewed Jul 21, 2026

fix(ui): throw warning pop-up when attempting to disable OOBM on acti…

068213b

…ve HA hosts (apache#13605)

Chinmay048 force-pushed the fix-13605-kvm-ha-oobm branch from 586999a to 068213b Compare July 21, 2026 10:36

Copilot AI review requested due to automatic review settings July 21, 2026 10:36

Copilot AI reviewed Jul 21, 2026

kiranchavala requested a review from Copilot July 21, 2026 13:18

Copilot started reviewing on behalf of kiranchavala July 21, 2026 13:18 View session

Copilot AI reviewed Jul 21, 2026

View reviewed changes

Damans227 reviewed Jul 21, 2026

View reviewed changes

DaanHoogland requested a review from Copilot July 21, 2026 19:25

Copilot started reviewing on behalf of DaanHoogland July 21, 2026 19:26 View session

Copilot AI reviewed Jul 21, 2026

View reviewed changes

Uh oh!

Conversation

Chinmay048 commented Jul 19, 2026

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Bug Severity

How Has This Been Tested?

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

kiranchavala commented Jul 20, 2026

Uh oh!

blueorangutan commented Jul 20, 2026

Uh oh!

codecov Bot commented Jul 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blueorangutan commented Jul 20, 2026

Uh oh!

kiranchavala commented Jul 20, 2026

Uh oh!

blueorangutan commented Jul 20, 2026

Uh oh!

blueorangutan commented Jul 20, 2026

Uh oh!

kiranchavala commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kiranchavala left a comment

Choose a reason for hiding this comment

Uh oh!

kiranchavala commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Chinmay048 commented Jul 21, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

kiranchavala commented Jul 21, 2026

Uh oh!

blueorangutan commented Jul 21, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

blueorangutan commented Jul 21, 2026

Uh oh!

winterhazel commented Jul 21, 2026

Uh oh!

Damans227 Jul 21, 2026

Choose a reason for hiding this comment

Uh oh!

Damans227 Jul 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov Bot commented Jul 20, 2026 •

edited

Loading

kiranchavala commented Jul 21, 2026 •

edited

Loading

kiranchavala commented Jul 21, 2026 •

edited

Loading